Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix messageGap metric (#12337)

This commit is contained in:
Yuanli Han 2022-03-29 00:21:06 +08:00 committed by GitHub
parent 9c6b9abcde
commit f2495a67d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server/src/main/java/org/apache/druid/segment/realtime/FireDepartmentMetrics.java
View File

@ -263,7 +263,8 @@ public class FireDepartmentMetrics
retVal.messageMaxTimestamp.set(messageMaxTimestamp.get()); retVal.messageMaxTimestamp.set(messageMaxTimestamp.get());
retVal.messageProcessingCompletionTime.set(messageProcessingCompletionTime.get()); retVal.messageProcessingCompletionTime.set(messageProcessingCompletionTime.get());
retVal.messageProcessingCompletionTime.compareAndSet(DEFAULT_PROCESSING_COMPLETION_TIME, System.currentTimeMillis()); retVal.messageProcessingCompletionTime.compareAndSet(DEFAULT_PROCESSING_COMPLETION_TIME, System.currentTimeMillis());
retVal.messageGap.set(retVal.messageProcessingCompletionTime.get() - messageMaxTimestamp.get()); long maxTimestamp = retVal.messageMaxTimestamp.get();
retVal.messageGap.set(maxTimestamp > 0 ? retVal.messageProcessingCompletionTime.get() - maxTimestamp : 0L);
return retVal; return retVal;
} }
} }

6
server/src/test/java/org/apache/druid/segment/realtime/FireDepartmentMetricsTest.java
View File

@ -33,6 +33,12 @@ public class FireDepartmentMetricsTest
metrics = new FireDepartmentMetrics(); metrics = new FireDepartmentMetrics();
} }
@Test
public void testSnapshotBeforeProcessing()
{
Assert.assertEquals(0L, metrics.snapshot().messageGap());
}
@Test @Test
public void testSnapshotAfterProcessingOver() public void testSnapshotAfterProcessingOver()
{ {