Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix crazy amounts of logging when coordinator loses leadership

This commit is contained in:
fjy 2014-11-21 15:46:14 -08:00
parent d5c86b7d63
commit f9db3a1fc6
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
server/src/main/java/io/druid/server/coordinator/helper/DruidCoordinatorRuleRunner.java
View File

@ -19,6 +19,8 @@
package io.druid.server.coordinator.helper; package io.druid.server.coordinator.helper;
import com.google.api.client.util.Maps;
import com.google.api.client.util.Sets;
import com.metamx.emitter.EmittingLogger; import com.metamx.emitter.EmittingLogger;
import io.druid.metadata.MetadataRuleManager; import io.druid.metadata.MetadataRuleManager;
import io.druid.server.coordinator.CoordinatorStats; import io.druid.server.coordinator.CoordinatorStats;
@ -31,6 +33,8 @@ import io.druid.timeline.DataSegment;
import org.joda.time.DateTime; import org.joda.time.DateTime;
import java.util.List; import java.util.List;
import java.util.Map;
import java.util.Set;
/** /**
*/ */
@ -87,6 +91,8 @@ public class DruidCoordinatorRuleRunner implements DruidCoordinatorHelper
// Run through all matched rules for available segments // Run through all matched rules for available segments
DateTime now = new DateTime(); DateTime now = new DateTime();
MetadataRuleManager databaseRuleManager = paramsWithReplicationManager.getDatabaseRuleManager(); MetadataRuleManager databaseRuleManager = paramsWithReplicationManager.getDatabaseRuleManager();
final Map<String, Set<String>> missingRules = Maps.newHashMap();
for (DataSegment segment : paramsWithReplicationManager.getAvailableSegments()) { for (DataSegment segment : paramsWithReplicationManager.getAvailableSegments()) {
List<Rule> rules = databaseRuleManager.getRulesWithDefault(segment.getDataSource()); List<Rule> rules = databaseRuleManager.getRulesWithDefault(segment.getDataSource());
boolean foundMatchingRule = false; boolean foundMatchingRule = false;
@ -99,13 +105,21 @@ public class DruidCoordinatorRuleRunner implements DruidCoordinatorHelper
} }
if (!foundMatchingRule) { if (!foundMatchingRule) {
log.makeAlert("Unable to find a matching rule!") Set<String> missingSegments = missingRules.get(segment.getDataSource());
.addData("dataSource", segment.getDataSource()) if (missingSegments == null) {
.addData("segment", segment.getIdentifier()) missingSegments = Sets.newHashSet();
.emit(); missingRules.put(segment.getDataSource(), missingSegments);
}
missingSegments.add(segment.getIdentifier());
} }
} }
if (!missingRules.isEmpty()) {
log.makeAlert("Unable to find a matching rules!")
.addData("missingSegments", missingRules)
.emit();
}
return paramsWithReplicationManager.buildFromExisting() return paramsWithReplicationManager.buildFromExisting()
.withCoordinatorStats(stats) .withCoordinatorStats(stats)
.build(); .build();