Justin Borromeo
287a367f41
Implemented Clint's recommendations
2019-03-27 20:03:41 -07:00
Justin Borromeo
231a72e7d9
Modified sequence limit to accept longs and added test for long limits
2019-03-27 17:38:20 -07:00
Justin Borromeo
1df50de321
Merge branch 'master' into 6088-Time-Ordering-On-Scans-N-Way-Merge
2019-03-26 15:23:01 -07:00
Justin Borromeo
c7fea6ac8f
Added better QueryInterruptedException error message for UnsupportedOperationException ( #7248 )
...
* Added error message for UOE
* Updated docs
* Doc change
* Doc change
2019-03-26 15:20:24 -07:00
Justin Borromeo
480e932fdf
Checkstyle and doc update
2019-03-26 14:58:04 -07:00
Justin Borromeo
487f31fcf6
Refixed regression
2019-03-26 14:39:25 -07:00
Justin Borromeo
fb858efbb7
Added test for n-way merge
2019-03-26 13:14:48 -07:00
Justin Borromeo
376e8bf906
Refactor n-way merge
2019-03-26 11:42:54 -07:00
Justin Borromeo
8a6bb1127c
Fix docs and flipped boolean in ScanQueryLimitRowIterator
2019-03-25 17:17:41 -07:00
Roman Leventov
bca40dcdaf
Fix some IntelliJ inspections ( #7273 )
...
Prepare TeamCity for IntelliJ 2018.3.1 upgrade. Mostly removed redundant exceptions declarations in `throws` clauses.
2019-03-25 21:11:01 -03:00
Justin Borromeo
35692680fc
Fix bug messing up count of rows
2019-03-25 16:15:49 -07:00
Justin Borromeo
219af478c8
Fix bug in numRowsScanned
2019-03-25 15:57:55 -07:00
Justin Borromeo
da4fc66403
Check type of segment spec before using for time ordering
2019-03-25 15:19:45 -07:00
Justin Borromeo
b822fc73df
Revert "Merge branch '6088-Time-Ordering-On-Scans-N-Way-Merge' of github.com:justinborromeo/incubator-druid into 6088-Time-Ordering-On-Scans-N-Way-Merge"
...
This reverts commit 57033f36df6e3ef887e5f0399ad74bb091306de8, reversing
changes made to 8f01d8dd16f40d10c60519ca0ec0d2e6b2dde941.
2019-03-25 13:19:02 -07:00
Justin Borromeo
86d9730fc9
Fixed failing tests -> allow usage of all types of segment spec
2019-03-25 11:01:35 -07:00
Justin Borromeo
8b3b6b51ed
Nit comment
2019-03-22 16:01:56 -07:00
Justin Borromeo
a87d02127c
Fix checkstyle and test
2019-03-22 15:54:42 -07:00
Justin Borromeo
62dcedacde
More comments
2019-03-22 15:30:41 -07:00
Justin Borromeo
1b46b58aec
Added a bit of docs
2019-03-22 15:19:52 -07:00
Justin Borromeo
49472162b7
Rename segment limit -> segment partitions limit
2019-03-22 10:27:41 -07:00
Justin Borromeo
43d490cc3a
Optimized n-way merge strategy
2019-03-21 13:16:58 -07:00
Justin Borromeo
42f5246b8d
Smarter limiting for pQueue method
2019-03-20 18:25:31 -07:00
Justin Borromeo
4823dab895
Finish rename
2019-03-20 16:05:53 -07:00
Justin Borromeo
2528a56142
Renaming
2019-03-18 14:00:50 -07:00
Jihoon Son
892d1d35d6
Deprecate NoneShardSpec and drop support for automatic segment merge ( #6883 )
...
* Deprecate noneShardSpec
* clean up noneShardSpec constructor
* revert unnecessary change
* Deprecate mergeTask
* add more doc
* remove convert from indexMerger
* Remove mergeTask
* remove HadoopDruidConverterConfig
* fix build
* fix build
* fix teamcity
* fix teamcity
* fix ServerModule
* fix compilation
* fix compilation
2019-03-15 23:29:25 -07:00
Furkan KAMACI
7ada1c49f9
Prohibit Throwables.propagate() ( #7121 )
...
* Throw caught exception.
* Throw caught exceptions.
* Related checkstyle rule is added to prevent further bugs.
* RuntimeException() is used instead of Throwables.propagate().
* Missing import is added.
* Throwables are propogated if possible.
* Throwables are propogated if possible.
* Throwables are propogated if possible.
* Throwables are propogated if possible.
* * Checkstyle definition is improved.
* Throwables.propagate() usages are removed.
* Checkstyle pattern is changed for only scanning "Throwables.propagate(" instead of checking lookbehind.
* Throwable is kept before firing a Runtime Exception.
* Fix unused assignments.
2019-03-14 18:28:33 -03:00
Furkan KAMACI
48bc523bdf
Locale problem is fixed which fails tests. ( #7120 )
...
* Locale problem is fixed which fails tests.
* Forbidden apis definition is improved to prevent using com.ibm.icu.text.SimpleDateFormat and com.ibm.icu.text.DateFormatSymbols without using any Locale defined.
* Error message is improved.
2019-03-13 18:47:14 -03:00
Gian Merlino
98a1b5537f
Fix time-extraction topN with non-STRING outputType. ( #7257 )
...
Similar to other bugs fixed in #6220 , but this one was missed. This bug would
cause "extraction" dimensionSpecs on the "__time" column with non-STRING
outputTypes to potentially be output as STRING sometimes instead of LONG,
causing incompletely merged results.
2019-03-13 13:53:07 -07:00
Justin Borromeo
7bfa77d3c1
Merge branch 'Update-Query-Interrupted-Exception' into 6088-Time-Ordering-On-Scans-N-Way-Merge
2019-03-12 16:57:45 -07:00
Justin Borromeo
7e49d47391
Added error message for UOE
2019-03-12 16:51:25 -07:00
Justin Borromeo
a032c46ee0
Updated error message
2019-03-12 16:47:17 -07:00
Justin Borromeo
57b5682654
Fixed tests
2019-03-12 12:44:02 -07:00
Justin Borromeo
45e95bb1f4
Optimization
2019-03-12 11:09:08 -07:00
Gian Merlino
4290e5ae7a
Cache selectors in QueryableIndexColumnSelectorFactory. ( #7216 )
...
For selectors with internal caches (like SingleScanTimeDimensionSelector,
SingleLongInputCachingExpressionColumnValueSelector, etc) we can get a perf
boost and memory usage decrease by sharing selectors.
2019-03-11 11:33:01 -07:00
Jihoon Son
9bebf113ba
Fix race in historical when loading segments in parallel ( #7203 )
...
* Fix race in historical when loading segments in parallel
* revert unnecessary change
* remove synchronized
* add reference counting locking
* fix build
* fix comment
2019-03-08 17:54:05 -08:00
Justin Borromeo
cce917ab84
Checkstyle fix
2019-03-08 14:11:07 -08:00
Justin Borromeo
73f4038068
Applied Jon's recommended changes
2019-03-07 18:40:00 -08:00
Justin Borromeo
fb966def83
Sorry, checkstyle
2019-03-07 11:03:01 -08:00
Justin Borromeo
6dc53b311c
Improved test and appeased TeamCity
2019-03-06 10:34:13 -08:00
Jonathan Wei
5486c2abf8
Update LICENSE and NOTICE files ( #7026 )
...
* Update LICENSE and NOTICE files
* Update react-table version
2019-03-04 18:45:22 -08:00
Justin Borromeo
35c96d3557
Checkstyle fix
2019-03-04 16:00:44 -08:00
Justin Borromeo
83ec3fe1f1
Nit-change on javadoc
2019-03-01 13:40:22 -08:00
Justin Borromeo
47c970b5f4
Wrote tests and added Javadoc
2019-03-01 13:38:29 -08:00
Justin Borromeo
5ff59f5ca6
Reset config
2019-02-28 15:58:20 -08:00
Justin Borromeo
806166f977
Fixed failing tests
2019-02-28 15:49:07 -08:00
Justin Borromeo
5bd0e1a32c
Merge branch 'master' into 6088-Time-Ordering-On-Scans-N-Way-Merge
2019-02-26 16:39:16 -08:00
Justin Borromeo
18cce9a646
Change so batching only occurs on broker for time-ordered scans
...
Restricted batching to broker for time-ordered queries and adjusted
tests
Formatting
Cleanup
2019-02-26 16:27:15 -08:00
Clint Wylie
9fa649b3bd
segment metadata fallback analysis if no bitmaps ( #7116 )
...
* segment metadata fallback analysis if no bitmaps
* remove accidental line
* remove nonsense size estimation
* less ternary
* fix it
* do the thing
2019-02-26 11:27:41 -08:00
Justin Borromeo
451e2b4365
WIP
2019-02-26 11:14:27 -08:00
Himanshu Pandey
8b803cbc22
Added checkstyle for "Methods starting with Capital Letters" ( #7118 )
...
* Added checkstyle for "Methods starting with Capital Letters" and changed the method names violating this.
* Un-abbreviate the method names in the calcite tests
* Fixed checkstyle errors
* Changed asserts position in the code
2019-02-23 20:10:31 -08:00