887c645675
Find duplicate lines with checkstyle; enable some duplicate inspections in IntelliJ ( #6558 )
...
Not putting this to 0.13 milestone because the found bugs are not critical (one is a harmless DI config duplicate, and another is in a benchmark.
Change in `DumpSegment` is just an indentation change.
2018-11-26 16:55:42 +01:00
87b96fb1fd
Add checkstyle rules about imports and empty lines between members ( #6543 )
...
* Add checkstyle rules about imports and empty lines between members
* Add suppressions
* Update Eclipse import order
* Add empty line
* Fix StatsDEmitter
2018-11-20 12:42:15 +01:00
8f3fe9cd02
Prohibit String.replace() and String.replaceAll(), fix and prohibit some toString()-related redundancies ( #6607 )
...
* Prohibit String.replace() and String.replaceAll(), fix and prohibit some toString()-related redundancies
* Fix bug
* Replace checkstyle regexp with IntelliJ inspection
2018-11-15 13:21:34 -08:00
afb239b17a
add missing license headers, in particular to MD files; clean up RAT … ( #6563 )
...
* add missing license headers, in particular to MD files; clean up RAT exclusions
* revert inadvertent doc changes
* docs
* cr changes
* fix modified druid-production.svg
2018-11-13 09:38:37 -08:00
54351a5c75
Fix various bugs; Enable more IntelliJ inspections and update error-prone ( #6490 )
...
* Fix various bugs; Enable more IntelliJ inspections and update error-prone
* Fix NPE
* Fix inspections
* Remove unused imports
2018-11-06 14:38:08 -08:00
a2a1a1c2c9
Hide NullDimensionSelector from public ( #6480 )
2018-11-02 04:38:21 -07:00
676f5e6d7f
Prohibit some guava collection APIs and use JDK collection APIs directly ( #6511 )
...
* Prohibit some guava collection APIs and use JDK APIs directly
* reset files that changed by accident
* sort codestyle/druid-forbidden-apis.txt alphabetically
2018-10-29 13:02:43 +01:00
ec9d1827a0
updated to use the latest sketches-core-0.12.0 ( #6381 )
2018-10-23 11:20:19 -07:00
84ac18dc1b
Catch some incorrect method parameter or call argument formatting patterns with checkstyle ( #6461 )
...
* Catch some incorrect method parameter or call argument formatting patterns with checkstyle
* Fix DiscoveryModule
* Inline parameters_and_arguments.txt
* Fix a bug in PolyBind
* Fix formatting
2018-10-23 07:17:38 -03:00
84598fba3b
combine druid-api, druid-common, java-util into druid-core ( #6443 )
...
* combine druid-api, druid-common, java-util
* spacing
2018-10-14 20:37:37 -07:00
20ab213ba6
change project versions to 0.13.0-incubating-SNAPSHOT ( #6453 )
2018-10-11 19:28:01 -07:00
3ae563263a
Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements ( #5957 )
...
This PR accumulates many refactorings and small improvements that I did while preparing the next change set of https://github.com/druid-io/druid/projects/2 . I finally decided to make them a separate PR to minimize the volume of the main PR.
Some of the changes:
- Renamed confusing "Generic Column" term to "Numeric Column" (what it actually implies) in many class names.
- Generified `ComplexMetricExtractor`
2018-10-02 14:50:22 -03:00
93345064b5
HllSketch module ( #5712 )
...
* HllSketch module
* updated license and imports
* updated package name
* implemented makeAggregateCombiner()
* removed json marks
* style fix
* added module
* removed unnecessary import, side effect of package renaming
* use TreadLocalRandom
* addressing code review points, mostly formatting and comments
* javadoc
* natural order with nulls
* typo
* factored out raw input value extraction
* singleton
* style fix
* style fix
* use Collections.singletonList instead of Arrays.asList
* suppress warning
2018-09-24 08:41:56 -07:00
0c4bd2b57b
Prohibit some Random usage patterns ( #6226 )
...
* Prohibit Random usage patterns
* Fix FlattenJSONBenchmarkUtil
2018-09-14 13:35:51 -07:00
431d3d8497
Rename io.druid to org.apache.druid. ( #6266 )
...
* Rename io.druid to org.apache.druid.
* Fix META-INF files and remove some benchmark results.
* MonitorsConfig update for metrics package migration.
* Reorder some dimensions in inner queries for some reason.
* Fix protobuf tests.
2018-08-30 09:56:26 -07:00
3647d4c94a
Make time-related variables more readable ( #6158 )
...
* Make time-related variables more readable
* Patch some improvements from the code reviewer
* Remove unnecessary boxing of Long type variables
2018-08-21 15:29:40 -07:00
c47032d566
Implemented makeAggregateCombiner() in ArrayOfDoublesSketchAggregatorFactory ( #6093 )
...
* implemented makeAggregateCombiner()
* test for makeAggregateCombiner()
* license, style fix
2018-08-13 14:19:11 -07:00
ecee3e0a24
Further optimize memory for Travis jobs ( #6150 )
...
* Further optimize memory for Travis jobs
* fix build
* sudo false
2018-08-10 22:03:36 -07:00
75c8a87ce1
Part 2 of changes for SQL Compatible Null Handling ( #5958 )
...
* Part 2 of changes for SQL Compatible Null Handling
* Review comments - break lines longer than 120 characters
* review comments
* review comments
* fix license
* fix test failure
* fix CalciteQueryTest failure
* Null Handling - Review comments
* review comments
* review comments
* fix checkstyle
* fix checkstyle
* remove unrelated change
* fix test failure
* fix failing test
* fix travis failures
* Make StringLast and StringFirst aggregators nullable and fix travis failures
2018-08-02 08:20:25 -07:00
331a0afb98
Remove redundant type parameters and enforce some other style and inspection rules ( #5980 )
...
* Various changes about druid-services module
* Patch improvements from reviewer
* Add ToArrayCallWithZeroLengthArrayArgument & ArraysAsListWithZeroOrOneArgument into inspection profile
* Fix ArraysAsListWithZeroOrOneArgument
* Fix conflict
* Fix ToArrayCallWithZeroLengthArrayArgument
* Fix AliEqualsAvoidNull
* Remove blank line
* Remove unused import clauses
* Fix code style in TopNQueryRunnerTest
* Fix conflict
* Don't use Collections.singletonList when converting the type of array type
* Add argLine into maven-surefire-plugin in druid-process module & increase the timeout value for testMoveSegment testcase
* Roll back the latest commit
* Add java.io.File#toURL() into druid-forbidden-apis
* Using Boolean.parseBoolean instead of Boolean.valueOf for CliCoordinator#isOverlord
* Add a new regexp element into stylecode xml file
* Fix style error for new regexp
* Set the level of ArraysAsListWithZeroOrOneArgument as WARNING
* Fix style error for new regexp
* Add option BY_LEVEL for ToArrayCallWithZeroLengthArrayArgument in inspection profile
* Roll back the level as ToArrayCallWithZeroLengthArrayArgument as ERROR
* Add toArray(new Object[0]) regexp into checkstyle config file & fix them
* Set the level of ArraysAsListWithZeroOrOneArgument as ERROR & Roll back the level of ToArrayCallWithZeroLengthArrayArgument as WARNING until Youtrack fix it
* Add a comment for string equals regexp in checkstyle config
* Fix code format
* Add RedundantTypeArguments as ERROR level inspection
* Fix cannot resolve symbol datasource
2018-07-27 16:56:49 -05:00
04ea3c9f8c
Update license headers. ( #5976 )
...
* Update license headers.
For compliance with http://www.apache.org/legal/src-headers.html .
* More license adjustments.
* Fix mistakenly edited package line.
2018-07-11 09:55:18 -07:00
15864434be
ArrayOfDoublesSketch module ( #5148 )
...
* ArrayOfDoublesSketch module
* UTF-8 fix
* javadoc, style fixes
* more style fixes
* null key selector fix
* more style fixes
* removed @Override, strict compiler doesn't like it
* removed @Override, strict compiler doesn't like it
* IndexedInts is not autoclosable? removed one more @0verride
* synchronized with upstream master
* removed unused imports
* addressed review points
* null fix
* addressed review points
* IAE from druid package
* synchronized aggregate() and get()
* use locks per buffer position
* corrected javadoc
* style fixes
* added lock and narrowed the scope
* addressed review comments
* conflict resolution went wrong
* addressed review comments
* javadoc
* javadoc links
* fully qualified name since there is no import for this class
* addressed review points
* style fix
* StandardCharsets.UTF_8
* addressed review points
* added @Override
* added equals and hashCode tests for post aggs
* formatting
* suppress warnings
* optimal IndexedInts iteration
* suppress SelfEquals
* added comments about getClass() in equals()
2018-05-13 15:48:00 +03:00
9be000758d
Refactor index merging, replace Rowboats with RowIterators and RowPointers ( #5335 )
...
* Refactor index merging, replace Rowboats with RowIterators and RowPointers
* Add javadocs
* Fix a bug in QueryableIndexIndexableAdapter
* Fixes
* Remove unused declarations
* Remove unused GenericColumn.isNull() method
* Fix test
* Address comments
* Rearrange some code in MergingRowIterator for more clarity
* Self-review
* Fix style
* Improve docs
* Fix docs
* Rename IndexMergerV9.writeDimValueAndSetupDimConversion to setUpDimConversion()
* Update Javadocs
* Minor fixes
* Doc fixes, more code comments, cleanup of RowCombiningTimeAndDimsIterator
* Fix doc link
2018-04-27 17:34:32 -07:00
a3a9ada843
Add GenericWhitespace checkstyle check ( #5668 )
2018-04-24 01:09:14 +05:30
685f4063d4
DoublesSketchModule: Fix serde for DoublesSketchMergeAggregatorFactory. ( #5587 )
...
Fixes #5580 .
2018-04-07 06:45:55 -07:00
371c672828
Adding feature thetaSketchConstant to do some set operation in PostAgg ( #5551 )
...
* Adding feature thetaSketchConstant to do some set operation in PostAggregator
* Updated review comments for PR #5551 - Adding thetaSketchConstant
* Fixed CI build issue
* Updated review comments 2 for PR #5551 - Adding thetaSketchConstant
2018-04-05 22:56:59 -07:00
8878a7ff94
Replace guava Charsets with native java StandardCharsets ( #5545 )
2018-03-28 21:00:08 -07:00
693e3575f9
Remove unused code and exception declarations ( #5461 )
...
* Remove unused code and exception declarations
* Address comments
* Remove redundant Exception declarations
* Make FirehoseFactoryV2.connect() to throw IOException again
2018-03-16 22:11:12 +01:00
e64ffb10c2
Standartize on using Integer.BYTES instead of Ints.BYTES from Guava, same for other primitives ( #5366 )
2018-02-07 13:24:30 -08:00
7e02408510
Update versions to 0.13.0-SNAPSHOT. ( #5323 )
2018-02-02 12:06:38 -06:00
80419752b5
Add metamx emitter, http clients, and metrics packages to druid java-util ( #5289 )
...
* Add metamx java-util emitter, http clients, and metrics packages to druid java-util
* Remove metamx java-util from pom.xml files
* Checkstyle fixes
* Import fix
* TeamCity inspection fixes
* Use slf4j, move some version defs to master pom.xml
* Use parent jvm-attach-api and maven-surefire-plugin versions
* Add ] to log msg, suppress inspection
2018-01-24 22:10:36 +01:00
a346bbc6f3
Enforce spacing around foreach colon with Checkstyle ( #5271 )
2018-01-22 11:48:51 -08:00
8877ce38d6
Enforce modifier order with Checkstyle ( #5246 )
2018-01-11 09:50:42 +01:00
579f9fbedf
Add IndexedInts.debugToString() and AbstractIndex.toString(); Add Sequence.toList() and limit() ( #5175 )
...
* Add IndexedInts.debugToString() and AbstractIndex.toString()
* Fix AppenderatorTest
2018-01-04 09:56:47 +09:00
f18eba50ee
Remove Aggregator.reset() ( #5177 )
2017-12-19 14:09:17 -08:00
5787d04fad
Bump Druid version to 0.12.0 ( #5138 )
2017-12-15 07:37:01 -08:00
80f5e89a11
Fix DoublesSketchComplexMetricSerde.getSerializer() ( #5140 )
2017-12-06 15:10:19 +09:00
45f91a241e
numeric quantiles sketch aggregator ( #5002 )
...
* numeric quantiles sketch aggregator
* it seems that we need to synchronize all methods, which modify the state
* Seems like a false positive with -Pstrict
* code style fix
* code style fix
* use sketches-core-0.10.3
* moved cache ids to the central place
* better class names
* support large columns
* explained autodetection, added exception
* added comments regarding sketches moving on heap
* support reindexing
* implemented suggestions from jihoonson
* style fix
* use max(k, other.k) for better accuracy
* check for NilColumnValueSelector instead of null
* throw exceptions instead of providing no-op comparators
2017-12-06 08:18:08 +09:00
a7a6a0487e
Replace IOPeon with SegmentWriteOutMedium; Improve buffer compression ( #4762 )
...
* Replace IOPeon with OutputMedium; Improve compression
* Fix test
* Cleanup CompressionStrategy
* Javadocs
* Add OutputBytesTest
* Address comments
* Random access in OutputBytes and GenericIndexedWriter
* Fix bugs
* Fixes
* Test OutputBytes.readFully()
* Address comments
* Rename OutputMedium to SegmentWriteOutMedium and OutputBytes to WriteOutBytes
* Add comments to ByteBufferInputStream
* Remove unused declarations
2017-12-04 18:04:27 -08:00
dc7cb117a1
Refactor ColumnSelectorFactory; Rely on ColumnValueSelector's polymorphism ( #4886 )
...
* Refactor ColumnSelectorFactory; Rely on ColumnValueSelector's polymorphism
* Fix MapVirtualColumn.makeColumnValueSelector()
* Minor fixes
* Fix IndexGeneratorCombinerTest
* DimensionSelector to return zeros when treated as numeric ColumnValueSelector
* Fix IncrementalIndexTest
* Fix IncrementalIndex.makeColumnSelectorFactory()
* Optimize MapBasedRow.getMetric()
* Fix VarianceAggregatorTest
* Simplify IncrementalIndex.makeColumnSelectorFactory()
* Address comments
* More comments
* Test
2017-10-13 21:44:17 -05:00
675c6c00dd
Add checkstyle and intellij rule to prohibit unnecessary qualifiers in interfaces ( #4958 )
...
* add checkstyle and intellij rule
* fix tc fail
2017-10-13 07:56:19 -07:00
bba96f59f8
added missing synchronized keyword ( #4894 )
...
* added missing synchronized keyword
* added missing synchronized keyword
2017-10-03 12:16:54 -05:00
1f2074c247
Bump versions in master to 0.11.1-SNAPSHOT. ( #4878 )
...
* Bump versions in master to 0.11.1-SNAPSHOT.
* Missed a few.
2017-09-28 17:09:51 -05:00
2c30d5ba55
Add org.joda.time.DateTime.parse() to forbidden APIs ( #4857 )
...
* Added org.joda.time.DateTime#(java.lang.String) to forbidden API.
* Added org.joda.time.DateTime#(java.lang.String, org.joda.time.format.DateTimeFormatter) to forbidden API.
* Add additional APIs that may create DateTime with default time zone
* Add helper function that accepts formatter to parse String.
* Add additional forbidden APIs
* Replace existing usage of forbidden APIs
* Use wrapper class to enforce Chronology on DateTimeFormatter.
* Creates constant UtcFormatter for constant ISODateTimeFormat.
2017-09-27 17:46:44 -05:00
c3fbe5158d
use latest sketches-core-0.10.1 and memory-0.10.3 ( #4828 )
...
* use latest sketches-core-0.10.1 and memory-0.10.3
* style fix
* better variable name
* removed explicit dependency on memory
2017-09-27 15:18:33 -05:00
88e9a80636
Rename ObjectValueSelector.get() to getObject(); Add getObject() and classOfObject() to ColumnValueSelector ( #4801 )
2017-09-19 14:47:20 -05:00
3a29521273
Fix GroupBy limit push down error when buffer is too small ( #4745 )
...
* Fix GroupBy limit push down error when buffer is too small
* Address PR comments
2017-09-12 12:34:50 -07:00
cacf63b007
Add AggregateCombiners ( #4676 )
...
* Add MetricCombiners
* Rename MetricCombiner to AggregateCombiner
* Spelling
* Fix TimestampAggregatorFactory.combine() and add makeAggregateCombiner() implementation
* Rename AggregateCombiner.combine() to fold()
2017-08-21 16:45:29 -07:00
cbd1902db8
Add forbidden-apis plugin; prohibit using system time zone ( #4611 )
...
* Forbidden APIs WIP
* Remove some tests
* Restore io.druid.math.expr.Function
* Integration tests fix
* Add comments
* Fix in SimpleWorkerProvisioningStrategy
* Formatting
* Replace String.format() with StringUtils.format() in RemoteTaskRunnerTest
* Address comments
* Fix GroupByMultiSegmentTest
2017-08-21 13:02:42 -07:00
aa7e4ae5e4
Enforce correct spacing with Checkstyle ( #4651 )
2017-08-05 10:18:25 -07:00
Roman Leventov
David Lim
QiuMM
Alexander Saydakov
Clint Wylie
David Lim
Gian Merlino
Benedict Jin
Jihoon Son
Nishant Bangarwa
Senthil Kumar L S
Kirill Kozlov
Jonathan Wei
Goh Wei Xiang