Fokko Driesprong
818bf4990c
Enable Spotbugs NP_NONNULL_RETURN_VIOLATION ( #8234 )
2019-08-20 17:23:46 +03:00
Fokko Driesprong
91743eeebe
Spotbugs: NP_NONNULL_PARAM_VIOLATION ( #8129 )
2019-08-02 19:20:22 +03:00
Fokko Driesprong
faf51107d5
Add SuppressWarnings SS_SHOULD_BE_STATIC ( #8138 )
...
* Spotbugs: SS_SHOULD_BE_STATIC (#8073 )
* Add SuppressWarnings SS_SHOULD_BE_STATIC
Fixes #8073
* Fix the voilation
* Make them non-final
* Remove @Nonnull
2019-07-31 19:44:42 +03:00
Fokko Driesprong
0f8c902e94
Spotbugs fix DM_NUMBER_CTOR ( #8072 )
2019-07-30 20:08:27 +03:00
Fokko Driesprong
e016995d1f
Enable Spotbugs: WMI_WRONG_MAP_ITERATOR ( #8005 )
...
* WMI_WRONG_MAP_ITERATOR
* Fixed missing loop
2019-07-30 19:51:53 +03:00
Fokko Driesprong
714a2726a7
Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN ( #8076 )
...
* Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN
* Use Objects instead
2019-07-24 16:17:02 -07:00
Clint Wylie
0388581493
Revert "Spotbugs: SS_SHOULD_BE_STATIC ( #8073 )" ( #8145 )
...
This reverts commit 04a180a5fb
.
2019-07-23 22:57:19 -07:00
Fokko Driesprong
04a180a5fb
Spotbugs: SS_SHOULD_BE_STATIC ( #8073 )
2019-07-23 18:18:49 +08:00
Fokko Driesprong
e1a745717e
Spotbugs: NP_STORE_INTO_NONNULL_FIELD ( #8021 )
2019-07-21 21:23:47 +08:00
Fokko Driesprong
0aabeb4b1a
Enable Spotbugs: MS_OOI_PKGPROTECT ( #8022 )
2019-07-08 13:17:56 +05:30
Fokko Driesprong
4508d3ff55
Enable RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE ( #7972 )
2019-07-01 11:25:06 +05:30
Fokko Driesprong
e8dedb3de4
Enable MS_MUTABLE_COLLECTION_PKGPROTECT ( #7971 )
2019-07-01 11:24:05 +05:30
Fokko Driesprong
c6baa59f77
Enable DLS_DEAD_LOCAL_STORE ( #7967 )
2019-06-28 04:39:42 +08:00
Fokko Driesprong
fba91b77d0
InterruptedException is never thrown ( #7963 )
...
And therefore the block will always be false
2019-06-27 22:21:36 +05:30
Fokko Driesprong
82b248cc17
Spotbugs: Enable MS_SHOULD_BE_FINAL ( #7946 )
2019-06-23 15:42:18 -07:00
Fokko Driesprong
48f20fe754
Add Spotbugs ( #7894 )
...
* Add Spotbugs
Exclude all the issues for now, so we can add them one by one.
(cherry picked from commit ceda4754dc8c703d1e0de85b48cd5f5409cfd5b7)
* Add additional rules to the list
* More rules
* More rules
* Add comments to the xml
* Move the spotbugs-exclude.xml to codestyle/
2019-06-20 21:06:52 +03:00