Nishant
1bf1dd03a0
Merge pull request #2812 from mrijke/fix-missing-equals-hashcode-filters
...
Add missing equals/hashcode to JS, Regex and SearchQuery DimFilters
2016-04-12 12:00:23 +05:30
Charles Allen
21e406613c
Merge pull request #2809 from metamx/fix2694
...
Fix test for snapshot taker to better check for lookup perist failure
2016-04-11 14:52:47 -07:00
Maarten Rijke
de68d6b7c4
Add missing equals/hashcode to JS, Regex and SearchQuery DimFilters
...
This commits adds missing equals() and hashcode() methods to
the JavascriptDimFilter, RegexDimFilter and the SearchQueryDimFilter.
2016-04-11 12:16:24 +02:00
Nishant
bbb326decf
Merge pull request #2799 from b-slim/fix_snapshot
...
MapLookupFactory need to be Ser/Desr ready.
2016-04-07 13:22:34 +05:30
Slim Bouguerra
bf1eafc4e1
remove all the mock lookupFactory
2016-04-06 15:37:52 -05:00
Slim Bouguerra
59eb2490a0
MapLookupFactory need to be Ser/Desr.
2016-04-06 15:02:18 -05:00
Charles Allen
f915a59138
Merge pull request #2691 from metamx/lookupExtrFn
...
Add ExtractionFn to LookupExtractor bridge
2016-04-06 09:13:08 -07:00
jon-wei
051fd6c0eb
Remove extra println from InFilter
2016-04-05 14:55:49 -07:00
Fangjin Yang
289bb6f885
Merge pull request #2690 from jon-wei/filter_support
...
Allow filters to use extraction functions
2016-04-05 15:40:15 -06:00
jon-wei
0e481d6f93
Allow filters to use extraction functions
2016-04-05 13:24:56 -07:00
Gian Merlino
e060a9f283
Additional ExtractionFn null-handling adjustments.
...
Followup to comments on #2771 .
2016-04-01 18:35:26 -07:00
Fangjin Yang
18b9ea62cf
Merge pull request #2771 from gianm/extractionfn-stuff
...
Various ExtractionFn null handling fixes.
2016-04-01 16:35:46 -07:00
Gian Merlino
23d66e5ff9
Merge pull request #2765 from navis/invalid-encode-nullstring
...
Null string is encoded as "null" in incremental index
2016-04-01 14:43:40 -07:00
Gian Merlino
b6e4d8b2c1
Various ExtractionFn null handling fixes.
...
- JavaScriptExtractionFn shouldn't pass empty strings to its JS functions
- Upper/LowerExtractionFn properly handles null Objects (DimExtractionFn's implementation works here)
- MatchingDimExtractionFn properly returns nulls rather than empties
- RegexDimExtractionFn properly attempts matching on nulls and empties
- SearchQuerySpecDimExtractionFn properly returns nulls when passed empties
2016-04-01 14:34:47 -07:00
Fangjin Yang
eea7a47870
Merge pull request #2576 from navis/paging-from-next
...
Add option for select query to get next page without modifying returned paging identifiers
2016-04-01 13:50:36 -07:00
Fangjin Yang
4eb5a2c4f1
Merge pull request #2715 from navis/stringformat-null-handling
...
stringFormat extractionFn should be able to return null on null values (Fix for #2706 )
2016-04-01 13:45:28 -07:00
Gian Merlino
23364a47fd
BaseFilterTest: Test optimized filters too.
2016-04-01 12:44:59 -07:00
navis.ryu
077522a46f
stringFormat extractionFn should be able to return null on null values (Fix for #2706 )
2016-04-01 13:40:56 +09:00
navis.ryu
f0e55f5d31
Null string is encoded as "null" in incremental index
2016-04-01 09:47:15 +09:00
navis.ryu
29bb00535b
Add option for select query to get next page without modifying returned paging identifiers
2016-04-01 09:03:03 +09:00
Gian Merlino
5f9240fcbc
Merge pull request #2577 from navis/native-in-filter
...
Implement native in filter
2016-03-30 20:02:54 -07:00
Fangjin Yang
3d68da94fe
Merge pull request #2661 from navis/utf8-estimated-length
...
Utility method for length estimation of utf8
2016-03-30 19:56:14 -07:00
navis.ryu
108535fd07
Implement native in filter (Fix for #2577 )
2016-03-31 10:10:57 +09:00
navis.ryu
e0cfd9ee19
Utility method for length estimation of utf8
2016-03-31 10:07:00 +09:00
jon-wei
5503bf1b38
Remove unnecessary type check in TimeAndDimsComp
2016-03-30 17:54:15 -07:00
Fangjin Yang
95733a362f
Merge pull request #2753 from gianm/null-filtering-multi-value-columns
...
More consistent empty-set filtering behavior on multi-value columns.
2016-03-29 18:52:25 -07:00
Charles Allen
95d42cfd9e
Merge pull request #2758 from pjain1/fix_npe_in_filter
...
handle null values in In Filter
2016-03-29 17:53:02 -07:00
Gian Merlino
1853f36e9f
More consistent empty-set filtering behavior on multi-value columns.
...
The behavior is now that filters on "null" will match rows with no
values. The behavior in the past was inconsistent; sometimes these
filters would match and sometimes they wouldn't.
Adds tests for this behavior to SelectorFilterTest and
BoundFilterTest, for query-level filters and filtered aggregates.
Fixes #2750 .
2016-03-29 15:32:13 -07:00
Parag Jain
d892918a3d
handle null values in In Filter
2016-03-29 17:03:26 -05:00
Fangjin Yang
e023df2b92
Merge pull request #2754 from gianm/i-dont-get-it
...
Remove error suppression code from IncrementalIndexAdapter.
2016-03-28 19:29:53 -07:00
Gian Merlino
c7ff0d698e
Remove error suppression code from IncrementalIndexAdapter.
2016-03-28 18:40:27 -07:00
fjy
c418a55638
cleanup distinct count agg
2016-03-28 17:29:41 -07:00
Fangjin Yang
9cb197adec
Merge pull request #2722 from himanshug/fix_hadoop_jar_upload
...
config to explicitly specify classpath for hadoop container during hadoop ingestion
2016-03-28 14:49:03 -07:00
Charles Allen
4a98c4fbac
Fix LookupExtractionFn equals and hashCode
2016-03-28 13:14:43 -07:00
Charles Allen
0ee861d0da
Add ExtractionFn to LookupExtractor bridge
2016-03-28 13:14:43 -07:00
Fangjin Yang
7fe277e6da
Merge pull request #2727 from gianm/optimize-bound-filter
...
BoundFilter optimizations, and related interface changes.
2016-03-26 18:59:05 -07:00
Fangjin Yang
0dae28b6af
Merge pull request #2729 from jon-wei/fix_hyperunique_comparator
...
Fix HyperUniquesAggregatorFactory comparator
2016-03-26 15:39:35 -07:00
Gian Merlino
2970b49adc
BoundFilter optimizations, and related interface changes.
...
BoundFilter:
- For lexicographic bounds, use bitmapIndex.getIndex to find the start and end points,
then union all bitmaps between those points.
- For alphanumeric bounds, iterate through dimValues, and union all bitmaps for values
matching the predicate.
- Change behavior for nulls: it used to be that the BoundFilter would never match nulls,
now it matches nulls if "" is allowed by the lower limit and not excluded by the
upper limit.
Interface changes:
- BitmapIndex: add `int getIndex(value)` to make it possible to get the index for a
value without retrieving the bitmap.
- BitmapIndex: remove `ImmutableBitmap getBitmap(value)`, change callers to `getBitmap(getIndex(value))`.
- BitmapIndexSelector: allow retrieving the underlying BitmapIndex through getBitmapIndex.
- Clarified contract of indexOf in Indexed, GenericIndexed.
Also added tests for SelectorFilter, NotFilter, and BoundFilter.
2016-03-25 14:11:48 -07:00
jon-wei
9afaa2b94a
Fix HyperUniquesAggregatorFactory comparator
2016-03-25 12:36:42 -07:00
Gian Merlino
4ac9e03161
Fix predicate-based ValueMatcher behavior for IncrementalIndex on missing columns.
...
Missing columns should be treated the same as columns containing 100% nulls.
2016-03-25 10:23:59 -07:00
Himanshu Gupta
e78a469fb7
UTs for ExtensionsConfig
2016-03-25 10:51:28 -05:00
Himanshu Gupta
004b00bb96
config to explicitly specify classpath for hadoop container during hadoop ingestion
2016-03-25 10:51:28 -05:00
Nishant
0b03c9405f
Merge pull request #2614 from sirpkt/calendric_gran
...
Support week, month, quarter, and year in query granularity
2016-03-24 16:21:01 -07:00
Himanshu
56343c6cdc
Merge pull request #2704 from navis/simple-optimize
...
optimize single elemented and/or filter
2016-03-24 16:13:48 -05:00
Gian Merlino
713062053c
Filters: Add filter.toFilter method, use that instead of the instanceof chain in Filters.
...
I believe that the instanceof chain in Filters exists because in the past, Filter
and DimFilter were in different packages (DimFilter was in druid-client and Filter
was in druid-processing). And since druid-client didn't depend on druid-processing,
DimFilter couldn't have a toFilter method. But now it can.
2016-03-23 17:03:49 -07:00
Gian Merlino
dd86198902
All Filters should work with FilteredAggregators.
...
This removes Filter.makeMatcher(ColumnSelectorFactory) and adds a
ValueMatcherFactory implementation to FilteredAggregatorFactory so it can
take advantage of existing makeMatcher(ValueMatcherFactory) implementations.
This patch also removes the Bound-based method from ValueMatcherFactory. Its
only user was the SpatialFilter, which could use the Predicate-based method.
Fixes #2604 .
2016-03-23 12:24:01 -07:00
binlijin
57d78d3293
clean tmp file when index merge fail
2016-03-23 10:55:12 +08:00
navis.ryu
91f6be4884
optimize single elemented and/or filter
2016-03-23 09:29:15 +09:00
Gian Merlino
ff25325f3b
Improved docs for multi-value dimensions.
...
- Add central doc for multi-value dimensions, with some content from other docs.
- Link to multi-value dimension doc from topN and groupBy docs.
- Fixes a broken link from dimensionspecs.md, which was presciently already
linking to this nonexistent doc.
- Resolve inconsistent naming in docs & code (sometimes "multi-valued", sometimes
"multi-value") in favor of "multi-value".
2016-03-22 14:40:55 -07:00
jon-wei
a59c9ee1b1
Support use of DimensionSchema class in DimensionsSpec
2016-03-21 13:12:04 -07:00