mirror of https://github.com/apache/druid.git
a934b2664c
This change removes ListenableFutures.transformAsync in favor of the existing Guava Futures.transform implementation. Our own implementation had a bug which did not fail the future if the applied function threw an exception, resulting in the future never completing. An attempt was made to fix this bug, however when running againts Guava's own tests, our version failed another half dozen tests, so it was decided to not continue down that path and scrap our own implementation. Explanation for how was this bug manifested itself: An exception thrown in BaseAppenderatorDriver.publishInBackground when invoked via transformAsync in StreamAppenderatorDriver.publish will cause the resulting future to never complete. This explains why when encountering https://github.com/apache/druid/issues/9845 the task will never complete, forever waiting for the publishFuture to register the handoff. As a result, the corresponding "Error while publishing segments ..." message only gets logged once the index task times out and is forcefully shutdown when the future is force-cancelled by the executor. |
||
|---|---|---|
| .. | ||
| LICENSE.txt | ||
| checkstyle-suppressions.xml | ||
| checkstyle.xml | ||
| druid-forbidden-apis.txt | ||
| joda-time-forbidden-apis.txt | ||
| spotbugs-exclude.xml | ||