Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
druid/.idea
History
Suneet Saldanha 303b02eba1
intelliJ inspections cleanup (#9260) 
* intelliJ inspections cleanup

- remove redundant escapes
- performance warnings
- access static member via instance reference
- static method declared final
- inner class may be static

Most of these changes are aesthetic, however, they will allow inspections to
be enabled as part of CI checks going forward

The valuable changes in this delta are:
- using StringBuilder instead of string addition in a loop
    indexing-hadoop/.../Utils.java
    processing/.../ByteBufferMinMaxOffsetHeap.java
- Use class variables instead of static variables for parameterized test
    processing/src/.../ScanQueryLimitRowIteratorTest.java

* Add intelliJ inspection warnings as errors to druid profile

* one more static inner class
 		2020-01-29 11:50:52 -08:00
..
inspectionProfiles intelliJ inspections cleanup (#9260) 2020-01-29 11:50:52 -08:00
scopes fix intellij UnusedInspectionsScope.xml (#7158) 2019-03-04 14:56:41 -08:00
xml-schemas Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings (#7541) 2019-04-25 11:21:58 -07:00
README.md Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings (#7541) 2019-04-25 11:21:58 -07:00
mavenProjectSettings.xml Make running test in Intellij work with JaCoCo (#8526) 2019-09-14 11:56:09 -07:00
misc.xml Implementing dropwizard emitter for druid (#7363) 2019-10-01 14:59:30 -07:00

README.md

Comments to various parts of IntelliJ's settings XML files. These comments cannot currently be placed close to the things that they are about, because IntelliJ keeps removing the comments from settings XML files: see https://youtrack.jetbrains.com/issue/IDEA-211087. Please vote for this issue to increase the chances that it's fixed faster. This Druid's issue records the fact that the comments should be moved when that IntelliJ's issue is fixed.

  1. inspectionProfiles/Druid.xml, StaticPseudoFunctionalStyleMethod is turned off because the current rate of false-positives produced by this inspection is very high, see https://youtrack.jetbrains.com/issue/IDEA-153047#focus=streamItem-27-3326648.0-0.

  2. misc.xml, ProjectResources component: this component is needed because IntelliJ verifies XML documents by the schema. XML documents usually reference those schemas as URLs:

<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">

But IntelliJ doesn't automatically go to the internet to download the resource. It needs to know what schema corresponds to what URL, statically. Hence the ProjectResources component.