From 02416b04ea5ecba78b03332444065297f77ecb6d Mon Sep 17 00:00:00 2001 From: Vinod Kumar Vavilapalli Date: Tue, 18 Sep 2012 00:41:44 +0000 Subject: [PATCH] YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. svn merge --ignore-ancestry -c 1386907 ../../trunk/ git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1386937 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-yarn-project/CHANGES.txt | 3 +++ .../apache/hadoop/yarn/util/TestCompositeService.java | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 8359b76efc1..110c4b31bf5 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -14,6 +14,9 @@ Release 2.0.3-alpha - Unreleased YARN-93. Fixed RM to propagate diagnostics from applications that have finished but failed (Jason Lowe via vinodkv). + YARN-28. Fixed TestCompositeService to not depend on test-order and thus + made it pass on JDK7 (Thomas Graves via vinodkv). + OPTIMIZATIONS BUG FIXES diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java index 7a8aef88f7d..67c2de16419 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java @@ -25,6 +25,7 @@ import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.yarn.YarnException; import org.apache.hadoop.yarn.service.CompositeService; import org.apache.hadoop.yarn.service.Service.STATE; +import org.junit.Before; import org.junit.Test; public class TestCompositeService { @@ -33,6 +34,11 @@ public class TestCompositeService { private static final int FAILED_SERVICE_SEQ_NUMBER = 2; + @Before + public void setup() { + CompositeServiceImpl.resetCounter(); + } + @Test public void testCallSequence() { ServiceManager serviceManager = new ServiceManager("ServiceManager"); @@ -226,6 +232,10 @@ public class TestCompositeService { counter = -1; } + public static void resetCounter() { + counter = -1; + } + public void setThrowExceptionOnStart(boolean throwExceptionOnStart) { this.throwExceptionOnStart = throwExceptionOnStart; }