diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 7bba416c83b..56918f8b2b9 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -64,6 +64,9 @@ Release 2.0.1-alpha - UNRELEASED HDFS-3433. GetImageServlet should allow administrative requestors when security is enabled. (atm) + HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. + (Ravi Phulari via eli) + Release 2.0.0-alpha - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java index f284aaa6702..3fdc2413dcf 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java @@ -587,6 +587,10 @@ class NamenodeJspHelper { whatNodes = request.getParameter("whatNodes"); // show only live or only // dead nodes + if (null == whatNodes || whatNodes.isEmpty()) { + out.print("Invalid input"); + return; + } sorterField = request.getParameter("sorter/field"); sorterOrder = request.getParameter("sorter/order"); if (sorterField == null) @@ -714,6 +718,8 @@ class NamenodeJspHelper { } out.print("\n"); } + } else { + out.print("Invalid input"); } out.print(""); }