Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-2390. dfsadmin -setBalancerBandwidth does not validate -ve value. Contributed by Gautam Gopalakrishnan.

This commit is contained in:
Harsh J 2015-08-27 16:22:48 +05:30
parent fdb56f74f3
commit 0bf285413f
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -359,6 +359,9 @@ Release 2.8.0 - UNRELEASED
IMPROVEMENTS IMPROVEMENTS
HDFS-2390. dfsadmin -setBalancerBandwidth does not validate -ve value
(Gautam Gopalakrishnan via harsh)
HDFS-8821. Explain message "Operation category X is not supported HDFS-8821. Explain message "Operation category X is not supported
in state standby" (Gautam Gopalakrishnan via harsh) in state standby" (Gautam Gopalakrishnan via harsh)

5
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
View File

@ -851,6 +851,11 @@ public class DFSAdmin extends FsShell {
return exitCode; return exitCode;
} }
if (bandwidth < 0) {
System.err.println("Bandwidth should be a non-negative integer");
return exitCode;
}
FileSystem fs = getFS(); FileSystem fs = getFS();
if (!(fs instanceof DistributedFileSystem)) { if (!(fs instanceof DistributedFileSystem)) {
System.err.println("FileSystem is " + fs.getUri()); System.err.println("FileSystem is " + fs.getUri());

7
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdminWithHA.java
View File

@ -192,6 +192,13 @@ public class TestDFSAdminWithHA {
assertOutputMatches(message + newLine + message + newLine); assertOutputMatches(message + newLine + message + newLine);
} }
@Test (timeout = 30000)
public void testSetNegativeBalancerBandwidth() throws Exception {
setUpHaCluster(false);
int exitCode = admin.run(new String[] {"-setBalancerBandwidth", "-10"});
assertEquals("Negative bandwidth value must fail the command", -1, exitCode);
}
@Test (timeout = 30000) @Test (timeout = 30000)
public void testMetaSave() throws Exception { public void testMetaSave() throws Exception {
setUpHaCluster(false); setUpHaCluster(false);