Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

YARN-9327. Improve synchronisation in ProtoUtils#convertToProtoFormat block. Contributed by Bibin A Chundatt.

This commit is contained in:
Sunil G 2019-07-02 11:44:11 +05:30
parent 570eee30e5
commit 0c8813f135
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java
View File

@ -412,7 +412,7 @@ public class ProtoUtils {
/* /*
* Resource * Resource
*/ */
public static synchronized ResourceProto convertToProtoFormat(Resource r) { public static ResourceProto convertToProtoFormat(Resource r) {
return ResourcePBImpl.getProto(r); return ResourcePBImpl.getProto(r);
} }

6
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java
View File

@ -75,14 +75,14 @@ public class ResourcePBImpl extends Resource {
initResources(); initResources();
} }
public ResourceProto getProto() { synchronized public ResourceProto getProto() {
mergeLocalToProto(); mergeLocalToProto();
proto = viaProto ? proto : builder.build(); proto = viaProto ? proto : builder.build();
viaProto = true; viaProto = true;
return proto; return proto;
} }
private void maybeInitBuilder() { synchronized private void maybeInitBuilder() {
if (viaProto || builder == null) { if (viaProto || builder == null) {
builder = ResourceProto.newBuilder(proto); builder = ResourceProto.newBuilder(proto);
} }
@ -131,7 +131,7 @@ public class ResourcePBImpl extends Resource {
resources[VCORES_INDEX].setValue(vCores); resources[VCORES_INDEX].setValue(vCores);
} }
private void initResources() { synchronized private void initResources() {
if (this.resources != null) { if (this.resources != null) {
return; return;
} }