Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-9635. Fix potential stack overflow in DomainSocket.c (V. Karthik Kumar via cmccabe) 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1491927 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Colin McCabe 2013-06-11 19:56:25 +00:00
parent 6f59922e9d
commit 0c88f38be8
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
View File

@ -276,12 +276,13 @@ JNIEnv *env, jclass clazz, jobject jstr, jint skipComponents)
jthrowable jthr = NULL; jthrowable jthr = NULL;
utfLength = (*env)->GetStringUTFLength(env, jstr); utfLength = (*env)->GetStringUTFLength(env, jstr);
if (utfLength > sizeof(path)) { if (utfLength > (sizeof(path)-1)) {
jthr = newIOException(env, "path is too long! We expected a path " jthr = newIOException(env, "path is too long! We expected a path "
"no longer than %zd UTF-8 bytes.", sizeof(path)); "no longer than %zd UTF-8 bytes.", (sizeof(path)-1));
goto done; goto done;
} }
(*env)->GetStringUTFRegion(env, jstr, 0, utfLength, path); (*env)->GetStringUTFRegion(env, jstr, 0, utfLength, path);
path [ utfLength ] = 0;
jthr = (*env)->ExceptionOccurred(env); jthr = (*env)->ExceptionOccurred(env);
if (jthr) { if (jthr) {
(*env)->ExceptionClear(env); (*env)->ExceptionClear(env);
@ -305,7 +306,7 @@ JNIEnv *env, jclass clazz, jobject jstr, jint skipComponents)
// be a directory. (If it is a directory, we will fail to create the socket // be a directory. (If it is a directory, we will fail to create the socket
// later with EISDIR or similar.) // later with EISDIR or similar.)
for (check[0] = '/', check[1] = '\0', rest = path, token = ""; for (check[0] = '/', check[1] = '\0', rest = path, token = "";
token && rest[0]; token && rest && rest[0];
token = strtok_r(rest, "/", &rest)) { token = strtok_r(rest, "/", &rest)) {
if (strcmp(check, "/") != 0) { if (strcmp(check, "/") != 0) {
// If the previous directory we checked was '/', we skip appending another // If the previous directory we checked was '/', we skip appending another

2
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -123,6 +123,8 @@ Trunk (Unreleased)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES
HADOOP-9635 Fix potential Stack Overflow in DomainSocket.c (V. Karthik Kumar
via cmccabe)
HDFS-2299. TestOfflineEditsViewer is failing on trunk. (Uma Maheswara Rao G HDFS-2299. TestOfflineEditsViewer is failing on trunk. (Uma Maheswara Rao G
via atm) via atm)