Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2 from saxenapranav/dfsHasCapablity-saxenapranav 

HDFS-16963: added asserts on the conditions used in FileSystem.hasPathCapablity
This commit is contained in:
Tsz-Wo Nicholas Sze 2023-03-24 15:38:22 +08:00 committed by GitHub
parent 51f7a875ae 6ddc4f245b
commit 0ec6f5c374
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/client/TestDfsPathCapabilities.java
View File

@ -23,6 +23,7 @@ import org.apache.hadoop.hdfs.DistributedFileSystem;
import org.apache.hadoop.hdfs.HdfsConfiguration; import org.apache.hadoop.hdfs.HdfsConfiguration;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
import org.mockito.Mockito;
import static org.apache.hadoop.fs.CommonPathCapabilities.FS_SYMLINKS; import static org.apache.hadoop.fs.CommonPathCapabilities.FS_SYMLINKS;
@ -37,16 +38,28 @@ public class TestDfsPathCapabilities {
conf.set(FileSystem.FS_DEFAULT_NAME_KEY, "hdfs://localhost/"); conf.set(FileSystem.FS_DEFAULT_NAME_KEY, "hdfs://localhost/");
final FileSystem fs = FileSystem.get(conf); final FileSystem fs = FileSystem.get(conf);
Assert.assertTrue(fs instanceof DistributedFileSystem); Assert.assertTrue(fs instanceof DistributedFileSystem);
final DistributedFileSystem dfs = (DistributedFileSystem) fs; final DistributedFileSystem dfs = Mockito.spy((DistributedFileSystem) fs);
final Path path = new Path("/"); final Path path = new Path("/");
Assert.assertTrue(dfs.supportsSymlinks());
// Symlinks disabled // Symlinks support disabled
Mockito.doReturn(false).when(dfs).supportsSymlinks();
Assert.assertFalse(FileSystem.areSymlinksEnabled());
Assert.assertFalse(dfs.hasPathCapability(path, FS_SYMLINKS));
// Symlinks support enabled
Mockito.doReturn(true).when(dfs).supportsSymlinks();
Assert.assertFalse(FileSystem.areSymlinksEnabled()); Assert.assertFalse(FileSystem.areSymlinksEnabled());
Assert.assertFalse(dfs.hasPathCapability(path, FS_SYMLINKS)); Assert.assertFalse(dfs.hasPathCapability(path, FS_SYMLINKS));
// Symlinks enabled // Symlinks enabled
FileSystem.enableSymlinks(); FileSystem.enableSymlinks();
Mockito.doReturn(true).when(dfs).supportsSymlinks();
Assert.assertTrue(FileSystem.areSymlinksEnabled());
Assert.assertTrue(dfs.hasPathCapability(path, FS_SYMLINKS));
// Symlinks enabled but symlink-support is disabled
FileSystem.enableSymlinks();
Mockito.doReturn(false).when(dfs).supportsSymlinks();
Assert.assertTrue(FileSystem.areSymlinksEnabled()); Assert.assertTrue(FileSystem.areSymlinksEnabled());
Assert.assertTrue(dfs.hasPathCapability(path, FS_SYMLINKS)); Assert.assertTrue(dfs.hasPathCapability(path, FS_SYMLINKS));
} }