Apache/hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-13175. Add more information for checking argument in DiskBalancerVolume.

Browse Source 
Contributed by  Lei (Eddy) Xu.
This commit is contained in:
Anu Engineer 2018-02-20 19:16:30 -08:00
parent b0d3c877e3
commit 121e1e1280
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/PlanCommand.java
View File

@ -124,6 +124,14 @@ public void execute(CommandLine cmd) throws Exception {
throw new IllegalArgumentException("Unable to find the specified node. " + throw new IllegalArgumentException("Unable to find the specified node. " +
cmd.getOptionValue(DiskBalancerCLI.PLAN)); cmd.getOptionValue(DiskBalancerCLI.PLAN));
} }
try (FSDataOutputStream beforeStream = create(String.format(
DiskBalancerCLI.BEFORE_TEMPLATE,
cmd.getOptionValue(DiskBalancerCLI.PLAN)))) {
beforeStream.write(getCluster().toJson()
.getBytes(StandardCharsets.UTF_8));
}
this.thresholdPercentage = getThresholdPercentage(cmd); this.thresholdPercentage = getThresholdPercentage(cmd);
LOG.debug("threshold Percentage is {}", this.thresholdPercentage); LOG.debug("threshold Percentage is {}", this.thresholdPercentage);
@ -138,14 +146,6 @@ public void execute(CommandLine cmd) throws Exception {
plan = plans.get(0); plan = plans.get(0);
} }
try (FSDataOutputStream beforeStream = create(String.format(
DiskBalancerCLI.BEFORE_TEMPLATE,
cmd.getOptionValue(DiskBalancerCLI.PLAN)))) {
beforeStream.write(getCluster().toJson()
.getBytes(StandardCharsets.UTF_8));
}
try { try {
if (plan != null && plan.getVolumeSetPlans().size() > 0) { if (plan != null && plan.getVolumeSetPlans().size() > 0) {
outputLine = String.format("Writing plan to:"); outputLine = String.format("Writing plan to:");

2
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/connectors/DBNameNodeConnector.java
View File

@ -144,8 +144,6 @@ private void getVolumeInfoFromStorageReports(DiskBalancerDataNode node,
// Does it make sense ? Balancer does do that. Right now // Does it make sense ? Balancer does do that. Right now
// we only deal with volumes and not blockPools // we only deal with volumes and not blockPools
volume.setUsed(report.getDfsUsed());
volume.setUuid(storage.getStorageID()); volume.setUuid(storage.getStorageID());
// we will skip this volume for disk balancer if // we will skip this volume for disk balancer if

4
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/datamodel/DiskBalancerVolume.java
View File

@ -269,7 +269,9 @@ public long getUsed() {
* @param dfsUsedSpace - dfsUsedSpace for this volume. * @param dfsUsedSpace - dfsUsedSpace for this volume.
*/ */
public void setUsed(long dfsUsedSpace) { public void setUsed(long dfsUsedSpace) {
Preconditions.checkArgument(dfsUsedSpace < this.getCapacity()); Preconditions.checkArgument(dfsUsedSpace < this.getCapacity(),
"DiskBalancerVolume.setUsed: dfsUsedSpace(%s) < capacity(%s)",
dfsUsedSpace, getCapacity());
this.used = dfsUsedSpace; this.used = dfsUsedSpace;
} }