From 1350539f2de158c08b47f336e8793e7aaecc8177 Mon Sep 17 00:00:00 2001
From: Gautham B A <gautham.bangalore@gmail.com>
Date: Wed, 11 May 2022 23:04:22 +0530
Subject: [PATCH] HDFS-16465. Remove redundant strings.h inclusions (#4279)

* Remove redundant strings.h inclusions

* strings.h was included in a bunch of
  C/C++ files and were redundant.
* Also, strings.h is not available on
  Windows and thus isn't cross-platform
  compatible.

* Build for all platforms in CI

* Revert "Build for all platforms in CI"

This reverts commit 2650f047bd6791a5908cfbe50cc8e70d42c512cb.

* Debug failure on Centos 8

* Skipping pipeline run on
  Centos 7 to debug the
  failure on Centos 8.

* Revert "Debug failure on Centos 8"

This reverts commit e365e34d6fab9df88f4df622910ddb28a8c8796f.
---
 .../src/main/native/fuse-dfs/fuse_dfs.h                          | 1 -
 .../src/main/native/fuse-dfs/fuse_trash.c                        | 1 -
 .../src/main/native/libhdfspp/lib/common/configuration.cc        | 1 -
 .../src/main/native/libhdfspp/lib/common/configuration_loader.cc | 1 -
 4 files changed, 4 deletions(-)

diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_dfs.h b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_dfs.h
index 4554dbdbea5..5ab8ac4131b 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_dfs.h
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_dfs.h
@@ -25,7 +25,6 @@
 #include <string.h>
 #include <errno.h>
 #include <assert.h>
-#include <strings.h>
 #include <syslog.h>
 
 #include <fuse.h>
diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_trash.c b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_trash.c
index 02f1b5f282c..23a00a28898 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_trash.c
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_trash.c
@@ -21,7 +21,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <strings.h>
 
 #include "fuse_context_handle.h"
 #include "fuse_dfs.h"
diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration.cc b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration.cc
index 947214bdbd5..8219740ef05 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration.cc
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration.cc
@@ -35,7 +35,6 @@
 #include "hdfspp/uri.h"
 #include "x-platform/syscall.h"
 
-#include <strings.h>
 #include <sstream>
 #include <map>
 #include <rapidxml/rapidxml.hpp>
diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration_loader.cc b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration_loader.cc
index 5301137505a..7d88550a81f 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration_loader.cc
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration_loader.cc
@@ -21,7 +21,6 @@
 #include "x-platform/syscall.h"
 
 #include <fstream>
-#include <strings.h>
 #include <sstream>
 #include <map>
 #include <sys/stat.h>