Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-3957. Change MutableQuantiles to use a shared thread for rolling over metrics. Contributed by Andrew Wang. 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1390211 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Todd Lipcon 2012-09-25 23:16:20 +00:00
parent 1aba4503cf
commit 1901c501c8
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -22,6 +22,9 @@ Release 2.0.3-alpha - Unreleased
HADOOP-8812. ExitUtil#terminate should print Exception#toString. (eli) HADOOP-8812. ExitUtil#terminate should print Exception#toString. (eli)
HADOOP-3957. Change MutableQuantiles to use a shared thread for rolling
over metrics. (Andrew Wang via todd)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES

6
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java
View File

@ -35,6 +35,7 @@ import org.apache.hadoop.metrics2.util.Quantile;
import org.apache.hadoop.metrics2.util.SampleQuantiles; import org.apache.hadoop.metrics2.util.SampleQuantiles;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
/** /**
* Watches a stream of long values, maintaining online estimates of specific * Watches a stream of long values, maintaining online estimates of specific
@ -60,8 +61,9 @@ public class MutableQuantiles extends MutableMetric {
@VisibleForTesting @VisibleForTesting
protected Map<Quantile, Long> previousSnapshot = null; protected Map<Quantile, Long> previousSnapshot = null;
private final ScheduledExecutorService scheduler = Executors private static final ScheduledExecutorService scheduler = Executors
.newScheduledThreadPool(1); .newScheduledThreadPool(1, new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("MutableQuantiles-%d").build());
/** /**
* Instantiates a new {@link MutableQuantiles} for a metric that rolls itself * Instantiates a new {@link MutableQuantiles} for a metric that rolls itself