Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1389875 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Joseph Evans 2012-09-25 14:22:17 +00:00
parent a7e450c7cc
commit 1a066944ba
2 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
dev-support/test-patch.sh
View File

@ -250,7 +250,7 @@ verifyPatch () {
echo "PATCH APPLICATION FAILED" echo "PATCH APPLICATION FAILED"
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 patch. The patch command could not apply the patch." {color:red}-1 patch{color}. The patch command could not apply the patch."
return 1 return 1
else else
return 0 return 0
@ -305,12 +305,12 @@ checkAuthor () {
if [[ $authorTags != 0 ]] ; then if [[ $authorTags != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 @author. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions." {color:red}-1 @author{color}. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
return 1 return 1
fi fi
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
+1 @author. The patch does not contain any @author tags." {color:green}+1 @author{color}. The patch does not contain any @author tags."
return 0 return 0
} }
@ -379,7 +379,7 @@ applyPatch () {
echo "PATCH APPLICATION FAILED" echo "PATCH APPLICATION FAILED"
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 patch. The patch command could not apply the patch." {color:red}-1 patch{color}. The patch command could not apply the patch."
return 1 return 1
fi fi
return 0 return 0
@ -416,12 +416,12 @@ checkJavadocWarnings () {
if [[ $javadocWarnings -ne $OK_JAVADOC_WARNINGS ]] ; then if [[ $javadocWarnings -ne $OK_JAVADOC_WARNINGS ]] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 javadoc. The javadoc tool appears to have generated `expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages." {color:red}-1 javadoc{color}. The javadoc tool appears to have generated `expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
return 1 return 1
fi fi
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
+1 javadoc. The javadoc tool did not generate any warning messages." {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages."
return 0 return 0
} }
@ -442,7 +442,7 @@ checkJavacWarnings () {
if [[ $? != 0 ]] ; then if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 javac. The patch appears to cause the build to fail." {color:red}-1 javac{color:red}. The patch appears to cause the build to fail."
return 2 return 2
fi fi
### Compare trunk and patch javac warning numbers ### Compare trunk and patch javac warning numbers
@ -456,7 +456,7 @@ checkJavacWarnings () {
if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 javac. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)." {color:red}-1 javac{color}. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)."
$DIFF $PATCH_DIR/filteredTrunkJavacWarnings.txt $PATCH_DIR/filteredPatchJavacWarnings.txt > $PATCH_DIR/diffJavacWarnings.txt $DIFF $PATCH_DIR/filteredTrunkJavacWarnings.txt $PATCH_DIR/filteredPatchJavacWarnings.txt > $PATCH_DIR/diffJavacWarnings.txt
JIRA_COMMENT_FOOTER="Javac warnings: $BUILD_URL/artifact/trunk/patchprocess/diffJavacWarnings.txt JIRA_COMMENT_FOOTER="Javac warnings: $BUILD_URL/artifact/trunk/patchprocess/diffJavacWarnings.txt
@ -468,7 +468,7 @@ $JIRA_COMMENT_FOOTER"
fi fi
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
+1 javac. The applied patch does not increase the total number of javac compiler warnings." {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings."
return 0 return 0
} }
@ -538,12 +538,12 @@ $JIRA_COMMENT_FOOTER"
# if [[ $patchStyleErrors != 0 ]] ; then # if [[ $patchStyleErrors != 0 ]] ; then
# JIRA_COMMENT="$JIRA_COMMENT # JIRA_COMMENT="$JIRA_COMMENT
# #
# -1 checkstyle. The patch generated $patchStyleErrors code style errors." # {color:red}-1 checkstyle{color}. The patch generated $patchStyleErrors code style errors."
# return 1 # return 1
# fi # fi
# JIRA_COMMENT="$JIRA_COMMENT # JIRA_COMMENT="$JIRA_COMMENT
# #
# +1 checkstyle. The patch generated 0 code style errors." # {color:green}+1 checkstyle{color}. The patch generated 0 code style errors."
return 0 return 0
} }
@ -595,7 +595,7 @@ checkFindbugsWarnings () {
if [ $rc != 0 ] ; then if [ $rc != 0 ] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 findbugs. The patch appears to cause Findbugs (version ${findbugs_version}) to fail." {color:red}-1 findbugs{color}. The patch appears to cause Findbugs (version ${findbugs_version}) to fail."
return 1 return 1
fi fi
@ -628,12 +628,12 @@ $JIRA_COMMENT_FOOTER"
if [[ $findbugsWarnings -gt 0 ]] ; then if [[ $findbugsWarnings -gt 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
-1 findbugs. The patch appears to introduce $findbugsWarnings new Findbugs (version ${findbugs_version}) warnings." {color:red}-1 findbugs{color}. The patch appears to introduce $findbugsWarnings new Findbugs (version ${findbugs_version}) warnings."
return 1 return 1
fi fi
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
+1 findbugs. The patch does not introduce any new Findbugs (version ${findbugs_version}) warnings." {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version ${findbugs_version}) warnings."
return 0 return 0
} }
@ -832,11 +832,11 @@ submitJiraComment () {
JIRA_COMMENT_FOOTER="" JIRA_COMMENT_FOOTER=""
fi fi
if [[ $result == 0 ]] ; then if [[ $result == 0 ]] ; then
comment="+1 overall. $JIRA_COMMENT comment="{color:green}+1 overall{color}. $JIRA_COMMENT
$JIRA_COMMENT_FOOTER" $JIRA_COMMENT_FOOTER"
else else
comment="-1 overall. $JIRA_COMMENT comment="{color:red}-1 overall{color}. $JIRA_COMMENT
$JIRA_COMMENT_FOOTER" $JIRA_COMMENT_FOOTER"
fi fi

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -111,6 +111,9 @@ Trunk (Unreleased)
HADOOP-7930. Kerberos relogin interval in UserGroupInformation HADOOP-7930. Kerberos relogin interval in UserGroupInformation
should be configurable (Robert Kanter via harsh) should be configurable (Robert Kanter via harsh)
HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via
bobby)
BUG FIXES BUG FIXES
HADOOP-8177. MBeans shouldn't try to register when it fails to create MBeanName. HADOOP-8177. MBeans shouldn't try to register when it fails to create MBeanName.