Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-8041. Log a warning when a failover is first attempted. Contributed by Todd Lipcon. 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/HDFS-1623@1242441 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Todd Lipcon 2012-02-09 18:25:44 +00:00
parent 5e26de982b
commit 1b4c990b61
2 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
View File

@ -45,3 +45,5 @@ ready before failing over. (eli)
HADOOP-8038. Add 'ipc.client.connect.max.retries.on.timeouts' entry in HADOOP-8038. Add 'ipc.client.connect.max.retries.on.timeouts' entry in
core-default.xml file. (Uma Maheswara Rao G via atm) core-default.xml file. (Uma Maheswara Rao G via atm)
HADOOP-8041. Log a warning when a failover is first attempted (todd)

27
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
View File

@ -39,6 +39,7 @@ class RetryInvocationHandler implements RpcInvocationHandler {
* The number of times the associated proxyProvider has ever been failed over. * The number of times the associated proxyProvider has ever been failed over.
*/ */
private long proxyProviderFailoverCount = 0; private long proxyProviderFailoverCount = 0;
private volatile boolean hasMadeASuccessfulCall = false;
private RetryPolicy defaultPolicy; private RetryPolicy defaultPolicy;
private Map<String,RetryPolicy> methodNameToPolicyMap; private Map<String,RetryPolicy> methodNameToPolicyMap;
@ -79,7 +80,9 @@ class RetryInvocationHandler implements RpcInvocationHandler {
invocationAttemptFailoverCount = proxyProviderFailoverCount; invocationAttemptFailoverCount = proxyProviderFailoverCount;
} }
try { try {
return invokeMethod(method, args); Object ret = invokeMethod(method, args);
hasMadeASuccessfulCall = true;
return ret;
} catch (Exception e) { } catch (Exception e) {
boolean isMethodIdempotent = proxyProvider.getInterface() boolean isMethodIdempotent = proxyProvider.getInterface()
.getMethod(method.getName(), method.getParameterTypes()) .getMethod(method.getName(), method.getParameterTypes())
@ -94,12 +97,20 @@ class RetryInvocationHandler implements RpcInvocationHandler {
} }
return null; return null;
} else { // retry or failover } else { // retry or failover
// avoid logging the failover if this is the first call on this
if (action.action == RetryAction.RetryDecision.FAILOVER_AND_RETRY) { // proxy object, and we successfully achieve the failover without
// any flip-flopping
boolean worthLogging =
!(invocationFailoverCount == 0 && !hasMadeASuccessfulCall);
worthLogging |= LOG.isDebugEnabled();
if (action.action == RetryAction.RetryDecision.FAILOVER_AND_RETRY &&
worthLogging) {
String msg = "Exception while invoking " + method.getName() String msg = "Exception while invoking " + method.getName()
+ " of " + currentProxy.getClass() + " of class " + currentProxy.getClass().getSimpleName();
+ " after " + invocationFailoverCount + " fail over attempts." if (invocationFailoverCount > 0) {
+ " Trying to fail over " + formatSleepMessage(action.delayMillis); msg += " after " + invocationFailoverCount + " fail over attempts";
}
msg += ". Trying to fail over " + formatSleepMessage(action.delayMillis);
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled()) {
LOG.debug(msg, e); LOG.debug(msg, e);
} else { } else {
@ -108,8 +119,8 @@ class RetryInvocationHandler implements RpcInvocationHandler {
} else { } else {
if(LOG.isDebugEnabled()) { if(LOG.isDebugEnabled()) {
LOG.debug("Exception while invoking " + method.getName() LOG.debug("Exception while invoking " + method.getName()
+ " of " + currentProxy.getClass() + ". Retrying " + + " of class " + currentProxy.getClass().getSimpleName() +
formatSleepMessage(action.delayMillis), e); ". Retrying " + formatSleepMessage(action.delayMillis), e);
} }
} }