diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index e07209a2eda..5fda4d6ad77 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -496,6 +496,9 @@ Release 2.6.1 - UNRELEASED HDFS-7443. Datanode upgrade to BLOCKID_BASED_LAYOUT fails if duplicate block files are present in the same volume (cmccabe) + HDFS-3443. Fix NPE when namenode transition to active during startup by + adding checkNNStartup() in NameNodeRpcServer. (Vinayakumar B via szetszwo) + Release 2.6.0 - 2014-11-18 INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java index a984a42d2f2..a5508bed90c 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java @@ -78,6 +78,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_DEFAULT_NAME_KEY; import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_TRASH_INTERVAL_DEFAULT; @@ -264,6 +265,7 @@ public class NameNode implements NameNodeStatusMXBean { private final boolean haEnabled; private final HAContext haContext; protected final boolean allowStaleStandbyReads; + private AtomicBoolean started = new AtomicBoolean(false); /** httpServer */ @@ -774,6 +776,7 @@ public class NameNode implements NameNodeStatusMXBean { this.stop(); throw e; } + this.started.set(true); } protected HAState createHAState(StartupOption startOpt) { @@ -1738,7 +1741,14 @@ public class NameNode implements NameNodeStatusMXBean { public boolean isActiveState() { return (state.equals(ACTIVE_STATE)); } - + + /** + * Returns whether the NameNode is completely started + */ + boolean isStarted() { + return this.started.get(); + } + /** * Check that a request to change this node's HA state is valid. * In particular, verifies that, if auto failover is enabled, non-forced diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java index 7c1a0be49ba..cc3682b96f6 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java @@ -68,7 +68,6 @@ import org.apache.hadoop.ha.protocolPB.HAServiceProtocolServerSideTranslatorPB; import org.apache.hadoop.hdfs.DFSConfigKeys; import org.apache.hadoop.hdfs.DFSUtil; import org.apache.hadoop.hdfs.HDFSPolicyProvider; -import org.apache.hadoop.hdfs.inotify.Event; import org.apache.hadoop.hdfs.inotify.EventBatch; import org.apache.hadoop.hdfs.inotify.EventBatchList; import org.apache.hadoop.hdfs.protocol.AclException; @@ -473,12 +472,14 @@ class NameNodeRpcServer implements NamenodeProtocols { throw new IllegalArgumentException( "Unexpected not positive size: "+size); } + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return namesystem.getBlockManager().getBlocks(datanode, size); } @Override // NamenodeProtocol public ExportedBlockKeys getBlockKeys() throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return namesystem.getBlockManager().getBlockKeys(); } @@ -487,6 +488,7 @@ class NameNodeRpcServer implements NamenodeProtocols { public void errorReport(NamenodeRegistration registration, int errorCode, String msg) throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.UNCHECKED); namesystem.checkSuperuserPrivilege(); verifyRequest(registration); @@ -499,6 +501,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // NamenodeProtocol public NamenodeRegistration registerSubordinateNamenode( NamenodeRegistration registration) throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); verifyLayoutVersion(registration.getVersion()); NamenodeRegistration myRegistration = nn.setRegistration(); @@ -508,7 +511,8 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // NamenodeProtocol public NamenodeCommand startCheckpoint(NamenodeRegistration registration) - throws IOException { + throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); verifyRequest(registration); if(!nn.isRole(NamenodeRole.NAMENODE)) @@ -531,6 +535,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // NamenodeProtocol public void endCheckpoint(NamenodeRegistration registration, CheckpointSignature sig) throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { @@ -548,18 +553,21 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public Token getDelegationToken(Text renewer) throws IOException { + checkNNStartup(); return namesystem.getDelegationToken(renewer); } @Override // ClientProtocol public long renewDelegationToken(Token token) throws InvalidToken, IOException { + checkNNStartup(); return namesystem.renewDelegationToken(token); } @Override // ClientProtocol public void cancelDelegationToken(Token token) throws IOException { + checkNNStartup(); namesystem.cancelDelegationToken(token); } @@ -568,6 +576,7 @@ class NameNodeRpcServer implements NamenodeProtocols { long offset, long length) throws IOException { + checkNNStartup(); metrics.incrGetBlockLocations(); return namesystem.getBlockLocations(getClientMachine(), src, offset, length); @@ -575,6 +584,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public FsServerDefaults getServerDefaults() throws IOException { + checkNNStartup(); return namesystem.getServerDefaults(); } @@ -584,6 +594,7 @@ class NameNodeRpcServer implements NamenodeProtocols { boolean createParent, short replication, long blockSize, CryptoProtocolVersion[] supportedVersions) throws IOException { + checkNNStartup(); String clientMachine = getClientMachine(); if (stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.create: file " @@ -618,6 +629,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public LastBlockWithStatus append(String src, String clientName) throws IOException { + checkNNStartup(); String clientMachine = getClientMachine(); if (stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.append: file " @@ -643,36 +655,42 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public boolean recoverLease(String src, String clientName) throws IOException { + checkNNStartup(); String clientMachine = getClientMachine(); return namesystem.recoverLease(src, clientName, clientMachine); } @Override // ClientProtocol public boolean setReplication(String src, short replication) - throws IOException { + throws IOException { + checkNNStartup(); return namesystem.setReplication(src, replication); } @Override public void setStoragePolicy(String src, String policyName) throws IOException { + checkNNStartup(); namesystem.setStoragePolicy(src, policyName); } @Override public BlockStoragePolicy[] getStoragePolicies() throws IOException { + checkNNStartup(); return namesystem.getStoragePolicies(); } @Override // ClientProtocol public void setPermission(String src, FsPermission permissions) throws IOException { + checkNNStartup(); namesystem.setPermission(src, permissions); } @Override // ClientProtocol public void setOwner(String src, String username, String groupname) throws IOException { + checkNNStartup(); namesystem.setOwner(src, username, groupname); } @@ -681,6 +699,7 @@ class NameNodeRpcServer implements NamenodeProtocols { ExtendedBlock previous, DatanodeInfo[] excludedNodes, long fileId, String[] favoredNodes) throws IOException { + checkNNStartup(); if (stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*BLOCK* NameNode.addBlock: file " + src + " fileId=" + fileId + " for " + clientName); @@ -708,6 +727,7 @@ class NameNodeRpcServer implements NamenodeProtocols { final DatanodeInfo[] excludes, final int numAdditionalNodes, final String clientName ) throws IOException { + checkNNStartup(); if (LOG.isDebugEnabled()) { LOG.debug("getAdditionalDatanode: src=" + src + ", fileId=" + fileId @@ -736,6 +756,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void abandonBlock(ExtendedBlock b, long fileId, String src, String holder) throws IOException { + checkNNStartup(); if(stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*BLOCK* NameNode.abandonBlock: " +b+" of file "+src); @@ -749,6 +770,7 @@ class NameNodeRpcServer implements NamenodeProtocols { public boolean complete(String src, String clientName, ExtendedBlock last, long fileId) throws IOException { + checkNNStartup(); if(stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.complete: " + src + " fileId=" + fileId +" for " + clientName); @@ -764,12 +786,14 @@ class NameNodeRpcServer implements NamenodeProtocols { */ @Override // ClientProtocol, DatanodeProtocol public void reportBadBlocks(LocatedBlock[] blocks) throws IOException { + checkNNStartup(); namesystem.reportBadBlocks(blocks); } @Override // ClientProtocol public LocatedBlock updateBlockForPipeline(ExtendedBlock block, String clientName) throws IOException { + checkNNStartup(); return namesystem.updateBlockForPipeline(block, clientName); } @@ -778,6 +802,7 @@ class NameNodeRpcServer implements NamenodeProtocols { public void updatePipeline(String clientName, ExtendedBlock oldBlock, ExtendedBlock newBlock, DatanodeID[] newNodes, String[] newStorageIDs) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -799,6 +824,7 @@ class NameNodeRpcServer implements NamenodeProtocols { boolean closeFile, boolean deleteblock, DatanodeID[] newtargets, String[] newtargetstorages) throws IOException { + checkNNStartup(); namesystem.commitBlockSynchronization(block, newgenerationstamp, newlength, closeFile, deleteblock, newtargets, newtargetstorages); } @@ -806,12 +832,14 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public long getPreferredBlockSize(String filename) throws IOException { + checkNNStartup(); return namesystem.getPreferredBlockSize(filename); } @Deprecated @Override // ClientProtocol public boolean rename(String src, String dst) throws IOException { + checkNNStartup(); if(stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.rename: " + src + " to " + dst); } @@ -839,6 +867,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void concat(String trg, String[] src) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -856,6 +885,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void rename2(String src, String dst, Options.Rename... options) throws IOException { + checkNNStartup(); if(stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.rename: " + src + " to " + dst); } @@ -879,6 +909,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public boolean delete(String src, boolean recursive) throws IOException { + checkNNStartup(); if (stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* Namenode.delete: src=" + src + ", recursive=" + recursive); @@ -913,6 +944,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public boolean mkdirs(String src, FsPermission masked, boolean createParent) throws IOException { + checkNNStartup(); if(stateChangeLog.isDebugEnabled()) { stateChangeLog.debug("*DIR* NameNode.mkdirs: " + src); } @@ -927,12 +959,14 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void renewLease(String clientName) throws IOException { + checkNNStartup(); namesystem.renewLease(clientName); } @Override // ClientProtocol public DirectoryListing getListing(String src, byte[] startAfter, boolean needLocation) throws IOException { + checkNNStartup(); DirectoryListing files = namesystem.getListing( src, startAfter, needLocation); if (files != null) { @@ -944,23 +978,27 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public HdfsFileStatus getFileInfo(String src) throws IOException { + checkNNStartup(); metrics.incrFileInfoOps(); return namesystem.getFileInfo(src, true); } @Override // ClientProtocol public boolean isFileClosed(String src) throws IOException{ + checkNNStartup(); return namesystem.isFileClosed(src); } @Override // ClientProtocol - public HdfsFileStatus getFileLinkInfo(String src) throws IOException { + public HdfsFileStatus getFileLinkInfo(String src) throws IOException { + checkNNStartup(); metrics.incrFileInfoOps(); return namesystem.getFileInfo(src, false); } @Override // ClientProtocol public long[] getStats() throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.READ); return namesystem.getStats(); } @@ -968,6 +1006,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public DatanodeInfo[] getDatanodeReport(DatanodeReportType type) throws IOException { + checkNNStartup(); DatanodeInfo results[] = namesystem.datanodeReport(type); return results; } @@ -975,6 +1014,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public DatanodeStorageReport[] getDatanodeStorageReport( DatanodeReportType type) throws IOException { + checkNNStartup(); final DatanodeStorageReport[] reports = namesystem.getDatanodeStorageReport(type); return reports; } @@ -982,6 +1022,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public boolean setSafeMode(SafeModeAction action, boolean isChecked) throws IOException { + checkNNStartup(); OperationCategory opCategory = OperationCategory.UNCHECKED; if (isChecked) { if (action == SafeModeAction.SAFEMODE_GET) { @@ -996,11 +1037,13 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public boolean restoreFailedStorage(String arg) throws IOException { + checkNNStartup(); return namesystem.restoreFailedStorage(arg); } @Override // ClientProtocol public void saveNamespace() throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1016,17 +1059,20 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public long rollEdits() throws AccessControlException, IOException { + checkNNStartup(); CheckpointSignature sig = namesystem.rollEditLog(); return sig.getCurSegmentTxId(); } @Override // ClientProtocol public void refreshNodes() throws IOException { + checkNNStartup(); namesystem.refreshNodes(); } @Override // NamenodeProtocol public long getTransactionID() throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.UNCHECKED); namesystem.checkSuperuserPrivilege(); return namesystem.getFSImage().getLastAppliedOrWrittenTxId(); @@ -1034,6 +1080,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // NamenodeProtocol public long getMostRecentCheckpointTxId() throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.UNCHECKED); namesystem.checkSuperuserPrivilege(); return namesystem.getFSImage().getMostRecentCheckpointTxId(); @@ -1041,13 +1088,15 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // NamenodeProtocol public CheckpointSignature rollEditLog() throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return namesystem.rollEditLog(); } @Override // NamenodeProtocol public RemoteEditLogManifest getEditLogManifest(long sinceTxId) - throws IOException { + throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.READ); namesystem.checkSuperuserPrivilege(); return namesystem.getEditLog().getEditLogManifest(sinceTxId); @@ -1055,11 +1104,13 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void finalizeUpgrade() throws IOException { + checkNNStartup(); namesystem.finalizeUpgrade(); } @Override // ClientProtocol public RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action) throws IOException { + checkNNStartup(); LOG.info("rollingUpgrade " + action); switch(action) { case QUERY: @@ -1076,12 +1127,14 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public void metaSave(String filename) throws IOException { + checkNNStartup(); namesystem.metaSave(filename); } @Override // ClientProtocol public CorruptFileBlocks listCorruptFileBlocks(String path, String cookie) throws IOException { + checkNNStartup(); String[] cookieTab = new String[] { cookie }; Collection fbs = namesystem.listCorruptFileBlocks(path, cookieTab); @@ -1102,17 +1155,20 @@ class NameNodeRpcServer implements NamenodeProtocols { */ @Override // ClientProtocol public void setBalancerBandwidth(long bandwidth) throws IOException { + checkNNStartup(); namesystem.setBalancerBandwidth(bandwidth); } @Override // ClientProtocol public ContentSummary getContentSummary(String path) throws IOException { + checkNNStartup(); return namesystem.getContentSummary(path); } @Override // ClientProtocol public void setQuota(String path, long namespaceQuota, long diskspaceQuota) throws IOException { + checkNNStartup(); namesystem.setQuota(path, namespaceQuota, diskspaceQuota); } @@ -1120,18 +1176,21 @@ class NameNodeRpcServer implements NamenodeProtocols { public void fsync(String src, long fileId, String clientName, long lastBlockLength) throws IOException { + checkNNStartup(); namesystem.fsync(src, fileId, clientName, lastBlockLength); } @Override // ClientProtocol public void setTimes(String src, long mtime, long atime) throws IOException { + checkNNStartup(); namesystem.setTimes(src, mtime, atime); } @Override // ClientProtocol public void createSymlink(String target, String link, FsPermission dirPerms, boolean createParent) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1162,6 +1221,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public String getLinkTarget(String path) throws IOException { + checkNNStartup(); metrics.incrGetLinkTargetOps(); HdfsFileStatus stat = null; try { @@ -1184,6 +1244,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // DatanodeProtocol public DatanodeRegistration registerDatanode(DatanodeRegistration nodeReg) throws IOException { + checkNNStartup(); verifySoftwareVersion(nodeReg); namesystem.registerDatanode(nodeReg); return nodeReg; @@ -1194,6 +1255,7 @@ class NameNodeRpcServer implements NamenodeProtocols { StorageReport[] report, long dnCacheCapacity, long dnCacheUsed, int xmitsInProgress, int xceiverCount, int failedVolumes) throws IOException { + checkNNStartup(); verifyRequest(nodeReg); return namesystem.handleHeartbeat(nodeReg, report, dnCacheCapacity, dnCacheUsed, xceiverCount, xmitsInProgress, @@ -1203,6 +1265,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // DatanodeProtocol public DatanodeCommand blockReport(DatanodeRegistration nodeReg, String poolId, StorageBlockReport[] reports) throws IOException { + checkNNStartup(); verifyRequest(nodeReg); if(blockStateChangeLog.isDebugEnabled()) { blockStateChangeLog.debug("*BLOCK* NameNode.blockReport: " @@ -1234,6 +1297,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override public DatanodeCommand cacheReport(DatanodeRegistration nodeReg, String poolId, List blockIds) throws IOException { + checkNNStartup(); verifyRequest(nodeReg); if (blockStateChangeLog.isDebugEnabled()) { blockStateChangeLog.debug("*BLOCK* NameNode.cacheReport: " @@ -1246,6 +1310,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // DatanodeProtocol public void blockReceivedAndDeleted(DatanodeRegistration nodeReg, String poolId, StorageReceivedDeletedBlocks[] receivedAndDeletedBlocks) throws IOException { + checkNNStartup(); verifyRequest(nodeReg); metrics.incrBlockReceivedAndDeletedOps(); if(blockStateChangeLog.isDebugEnabled()) { @@ -1261,6 +1326,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // DatanodeProtocol public void errorReport(DatanodeRegistration nodeReg, int errorCode, String msg) throws IOException { + checkNNStartup(); String dnName = (nodeReg == null) ? "Unknown DataNode" : nodeReg.toString(); @@ -1282,6 +1348,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // DatanodeProtocol, NamenodeProtocol public NamespaceInfo versionRequest() throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return namesystem.getNamespaceInfo(); } @@ -1307,6 +1374,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // RefreshAuthorizationPolicyProtocol public void refreshServiceAcl() throws IOException { + checkNNStartup(); if (!serviceAuthEnabled) { throw new AuthorizationException("Service Level Authorization not enabled!"); } @@ -1357,28 +1425,32 @@ class NameNodeRpcServer implements NamenodeProtocols { } @Override // HAServiceProtocol - public synchronized void monitorHealth() - throws HealthCheckFailedException, AccessControlException { + public synchronized void monitorHealth() throws HealthCheckFailedException, + AccessControlException, IOException { + checkNNStartup(); nn.monitorHealth(); } @Override // HAServiceProtocol public synchronized void transitionToActive(StateChangeRequestInfo req) - throws ServiceFailedException, AccessControlException { + throws ServiceFailedException, AccessControlException, IOException { + checkNNStartup(); nn.checkHaStateChange(req); nn.transitionToActive(); } @Override // HAServiceProtocol public synchronized void transitionToStandby(StateChangeRequestInfo req) - throws ServiceFailedException, AccessControlException { + throws ServiceFailedException, AccessControlException, IOException { + checkNNStartup(); nn.checkHaStateChange(req); nn.transitionToStandby(); } @Override // HAServiceProtocol public synchronized HAServiceStatus getServiceStatus() - throws AccessControlException, ServiceFailedException { + throws AccessControlException, ServiceFailedException, IOException { + checkNNStartup(); return nn.getServiceStatus(); } @@ -1435,12 +1507,14 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override public DataEncryptionKey getDataEncryptionKey() throws IOException { + checkNNStartup(); return namesystem.getBlockManager().generateDataEncryptionKey(); } @Override public String createSnapshot(String snapshotRoot, String snapshotName) throws IOException { + checkNNStartup(); if (!checkPathLength(snapshotRoot)) { throw new IOException("createSnapshot: Pathname too long. Limit " + MAX_PATH_LENGTH + " characters, " + MAX_PATH_DEPTH + " levels."); @@ -1465,6 +1539,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override public void deleteSnapshot(String snapshotRoot, String snapshotName) throws IOException { + checkNNStartup(); metrics.incrDeleteSnapshotOps(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { @@ -1482,6 +1557,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // Client Protocol public void allowSnapshot(String snapshotRoot) throws IOException { + checkNNStartup(); metrics.incrAllowSnapshotOps(); namesystem.allowSnapshot(snapshotRoot); } @@ -1489,13 +1565,16 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // Client Protocol public void disallowSnapshot(String snapshot) throws IOException { + checkNNStartup(); metrics.incrDisAllowSnapshotOps(); namesystem.disallowSnapshot(snapshot); } @Override + // ClientProtocol public void renameSnapshot(String snapshotRoot, String snapshotOldName, String snapshotNewName) throws IOException { + checkNNStartup(); if (snapshotNewName == null || snapshotNewName.isEmpty()) { throw new IOException("The new snapshot name is null or empty."); } @@ -1517,24 +1596,27 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // Client Protocol public SnapshottableDirectoryStatus[] getSnapshottableDirListing() throws IOException { + checkNNStartup(); SnapshottableDirectoryStatus[] status = namesystem .getSnapshottableDirListing(); metrics.incrListSnapshottableDirOps(); return status; } - @Override + @Override // ClientProtocol public SnapshotDiffReport getSnapshotDiffReport(String snapshotRoot, String earlierSnapshotName, String laterSnapshotName) throws IOException { + checkNNStartup(); SnapshotDiffReport report = namesystem.getSnapshotDiffReport(snapshotRoot, earlierSnapshotName, laterSnapshotName); metrics.incrSnapshotDiffReportOps(); return report; } - @Override + @Override // ClientProtocol public long addCacheDirective( CacheDirectiveInfo path, EnumSet flags) throws IOException { + checkNNStartup(); CacheEntryWithPayload cacheEntry = RetryCache.waitForCompletion (retryCache, null); if (cacheEntry != null && cacheEntry.isSuccess()) { @@ -1552,9 +1634,10 @@ class NameNodeRpcServer implements NamenodeProtocols { return ret; } - @Override + @Override // ClientProtocol public void modifyCacheDirective( CacheDirectiveInfo directive, EnumSet flags) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; @@ -1569,8 +1652,9 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public void removeCacheDirective(long id) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; @@ -1584,17 +1668,19 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public BatchedEntries listCacheDirectives(long prevId, CacheDirectiveInfo filter) throws IOException { + checkNNStartup(); if (filter == null) { filter = new CacheDirectiveInfo.Builder().build(); } return namesystem.listCacheDirectives(prevId, filter); } - @Override + @Override //ClientProtocol public void addCachePool(CachePoolInfo info) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1608,8 +1694,9 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public void modifyCachePool(CachePoolInfo info) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1623,8 +1710,9 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public void removeCachePool(String cachePoolName) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; @@ -1638,47 +1726,55 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public BatchedEntries listCachePools(String prevKey) throws IOException { + checkNNStartup(); return namesystem.listCachePools(prevKey != null ? prevKey : ""); } - @Override + @Override // ClientProtocol public void modifyAclEntries(String src, List aclSpec) throws IOException { + checkNNStartup(); namesystem.modifyAclEntries(src, aclSpec); } - @Override + @Override // ClienProtocol public void removeAclEntries(String src, List aclSpec) throws IOException { + checkNNStartup(); namesystem.removeAclEntries(src, aclSpec); } - @Override + @Override // ClientProtocol public void removeDefaultAcl(String src) throws IOException { + checkNNStartup(); namesystem.removeDefaultAcl(src); } - @Override + @Override // ClientProtocol public void removeAcl(String src) throws IOException { + checkNNStartup(); namesystem.removeAcl(src); } - @Override + @Override // ClientProtocol public void setAcl(String src, List aclSpec) throws IOException { + checkNNStartup(); namesystem.setAcl(src, aclSpec); } - @Override + @Override // ClientProtocol public AclStatus getAclStatus(String src) throws IOException { + checkNNStartup(); return namesystem.getAclStatus(src); } - @Override + @Override // ClientProtocol public void createEncryptionZone(String src, String keyName) throws IOException { + checkNNStartup(); final CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; @@ -1692,21 +1788,24 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public EncryptionZone getEZForPath(String src) throws IOException { + checkNNStartup(); return namesystem.getEZForPath(src); } - @Override + @Override // ClientProtocol public BatchedEntries listEncryptionZones( long prevId) throws IOException { + checkNNStartup(); return namesystem.listEncryptionZones(prevId); } - @Override + @Override // ClientProtocol public void setXAttr(String src, XAttr xAttr, EnumSet flag) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1720,19 +1819,22 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + @Override // ClientProtocol public List getXAttrs(String src, List xAttrs) throws IOException { + checkNNStartup(); return namesystem.getXAttrs(src, xAttrs); } - @Override + @Override // ClientProtocol public List listXAttrs(String src) throws IOException { + checkNNStartup(); return namesystem.listXAttrs(src); } - @Override + @Override // ClientProtocol public void removeXAttr(String src, XAttr xAttr) throws IOException { + checkNNStartup(); CacheEntry cacheEntry = RetryCache.waitForCompletion(retryCache); if (cacheEntry != null && cacheEntry.isSuccess()) { return; // Return previous response @@ -1746,13 +1848,21 @@ class NameNodeRpcServer implements NamenodeProtocols { } } - @Override + private void checkNNStartup() throws IOException { + if (!this.nn.isStarted()) { + throw new IOException(this.nn.getRole() + " still not started"); + } + } + + @Override // ClientProtocol public void checkAccess(String path, FsAction mode) throws IOException { + checkNNStartup(); namesystem.checkAccess(path, mode); } @Override // ClientProtocol public long getCurrentEditLogTxid() throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.READ); // only active namesystem.checkSuperuserPrivilege(); // if it's not yet open for write, we may be in the process of transitioning @@ -1781,6 +1891,7 @@ class NameNodeRpcServer implements NamenodeProtocols { @Override // ClientProtocol public EventBatchList getEditsFromTxid(long txid) throws IOException { + checkNNStartup(); namesystem.checkOperation(OperationCategory.READ); // only active namesystem.checkSuperuserPrivilege(); int maxEventsPerRPC = nn.conf.getInt( @@ -1864,20 +1975,23 @@ class NameNodeRpcServer implements NamenodeProtocols { return new EventBatchList(batches, firstSeenTxid, maxSeenTxid, syncTxid); } - @Override + @Override // TraceAdminProtocol public SpanReceiverInfo[] listSpanReceivers() throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return nn.spanReceiverHost.listSpanReceivers(); } - @Override + @Override // TraceAdminProtocol public long addSpanReceiver(SpanReceiverInfo info) throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); return nn.spanReceiverHost.addSpanReceiver(info); } - @Override + @Override // TraceAdminProtocol public void removeSpanReceiver(long id) throws IOException { + checkNNStartup(); namesystem.checkSuperuserPrivilege(); nn.spanReceiverHost.removeSpanReceiver(id); }