YARN-9795. ClusterMetrics to include AM allocation delay. Contributed by Fengnan Li.
This commit is contained in:
parent
3cc21350b5
commit
1f6f4a2457
|
@ -48,6 +48,8 @@ public class ClusterMetrics {
|
||||||
@Metric("# of Shutdown NMs") MutableGaugeInt numShutdownNMs;
|
@Metric("# of Shutdown NMs") MutableGaugeInt numShutdownNMs;
|
||||||
@Metric("AM container launch delay") MutableRate aMLaunchDelay;
|
@Metric("AM container launch delay") MutableRate aMLaunchDelay;
|
||||||
@Metric("AM register delay") MutableRate aMRegisterDelay;
|
@Metric("AM register delay") MutableRate aMRegisterDelay;
|
||||||
|
@Metric("AM container allocation delay")
|
||||||
|
private MutableRate aMContainerAllocationDelay;
|
||||||
|
|
||||||
private static final MetricsInfo RECORD_INFO = info("ClusterMetrics",
|
private static final MetricsInfo RECORD_INFO = info("ClusterMetrics",
|
||||||
"Metrics for the Yarn Cluster");
|
"Metrics for the Yarn Cluster");
|
||||||
|
@ -190,4 +192,11 @@ public class ClusterMetrics {
|
||||||
aMRegisterDelay.add(delay);
|
aMRegisterDelay.add(delay);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public void addAMContainerAllocationDelay(long delay) {
|
||||||
|
aMContainerAllocationDelay.add(delay);
|
||||||
|
}
|
||||||
|
|
||||||
|
public MutableRate getAMContainerAllocationDelay() {
|
||||||
|
return aMContainerAllocationDelay;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -176,6 +176,8 @@ public class RMAppAttemptImpl implements RMAppAttempt, Recoverable {
|
||||||
private long finishTime = 0;
|
private long finishTime = 0;
|
||||||
private long launchAMStartTime = 0;
|
private long launchAMStartTime = 0;
|
||||||
private long launchAMEndTime = 0;
|
private long launchAMEndTime = 0;
|
||||||
|
private long scheduledTime = 0;
|
||||||
|
private long containerAllocatedTime = 0;
|
||||||
|
|
||||||
// Set to null initially. Will eventually get set
|
// Set to null initially. Will eventually get set
|
||||||
// if an RMAppAttemptUnregistrationEvent occurs
|
// if an RMAppAttemptUnregistrationEvent occurs
|
||||||
|
@ -1170,6 +1172,7 @@ public class RMAppAttemptImpl implements RMAppAttempt, Recoverable {
|
||||||
&& amContainerAllocation.getContainers() != null) {
|
&& amContainerAllocation.getContainers() != null) {
|
||||||
assert (amContainerAllocation.getContainers().size() == 0);
|
assert (amContainerAllocation.getContainers().size() == 0);
|
||||||
}
|
}
|
||||||
|
appAttempt.scheduledTime = System.currentTimeMillis();
|
||||||
return RMAppAttemptState.SCHEDULED;
|
return RMAppAttemptState.SCHEDULED;
|
||||||
} else {
|
} else {
|
||||||
// save state and then go to LAUNCHED state
|
// save state and then go to LAUNCHED state
|
||||||
|
@ -1226,6 +1229,11 @@ public class RMAppAttemptImpl implements RMAppAttempt, Recoverable {
|
||||||
.clearNodeSetForAttempt(appAttempt.applicationAttemptId);
|
.clearNodeSetForAttempt(appAttempt.applicationAttemptId);
|
||||||
appAttempt.getSubmissionContext().setResource(
|
appAttempt.getSubmissionContext().setResource(
|
||||||
appAttempt.getMasterContainer().getResource());
|
appAttempt.getMasterContainer().getResource());
|
||||||
|
appAttempt.containerAllocatedTime = System.currentTimeMillis();
|
||||||
|
long allocationDelay =
|
||||||
|
appAttempt.containerAllocatedTime - appAttempt.scheduledTime;
|
||||||
|
ClusterMetrics.getMetrics().addAMContainerAllocationDelay(
|
||||||
|
allocationDelay);
|
||||||
appAttempt.storeAttempt();
|
appAttempt.storeAttempt();
|
||||||
return RMAppAttemptState.ALLOCATED_SAVING;
|
return RMAppAttemptState.ALLOCATED_SAVING;
|
||||||
}
|
}
|
||||||
|
|
|
@ -29,17 +29,23 @@ public class TestClusterMetrics {
|
||||||
|
|
||||||
private ClusterMetrics metrics;
|
private ClusterMetrics metrics;
|
||||||
/**
|
/**
|
||||||
* Test aMLaunchDelay and aMRegisterDelay Metrics
|
* Test below metrics
|
||||||
|
* - aMLaunchDelay
|
||||||
|
* - aMRegisterDelay
|
||||||
|
* - aMContainerAllocationDelay
|
||||||
*/
|
*/
|
||||||
@Test
|
@Test
|
||||||
public void testAmMetrics() throws Exception {
|
public void testAmMetrics() throws Exception {
|
||||||
assert(metrics != null);
|
assert(metrics != null);
|
||||||
Assert.assertTrue(!metrics.aMLaunchDelay.changed());
|
Assert.assertTrue(!metrics.aMLaunchDelay.changed());
|
||||||
Assert.assertTrue(!metrics.aMRegisterDelay.changed());
|
Assert.assertTrue(!metrics.aMRegisterDelay.changed());
|
||||||
|
Assert.assertTrue(!metrics.getAMContainerAllocationDelay().changed());
|
||||||
metrics.addAMLaunchDelay(1);
|
metrics.addAMLaunchDelay(1);
|
||||||
metrics.addAMRegisterDelay(1);
|
metrics.addAMRegisterDelay(1);
|
||||||
|
metrics.addAMContainerAllocationDelay(1);
|
||||||
Assert.assertTrue(metrics.aMLaunchDelay.changed());
|
Assert.assertTrue(metrics.aMLaunchDelay.changed());
|
||||||
Assert.assertTrue(metrics.aMRegisterDelay.changed());
|
Assert.assertTrue(metrics.aMRegisterDelay.changed());
|
||||||
|
Assert.assertTrue(metrics.getAMContainerAllocationDelay().changed());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Before
|
@Before
|
||||||
|
|
Loading…
Reference in New Issue