From 21b4ba48ce3f6e8d7e7895202ad22978c9be392d Mon Sep 17 00:00:00 2001 From: Harsh J Date: Sat, 3 Oct 2015 18:37:58 +0530 Subject: [PATCH] HADOOP-12458. Retries is typoed to spell Retires in parts of hadoop-yarn and hadoop-common. Contributed by Neelesh Srinivas Salian. (cherry picked from commit c918f7be5e6aecaa3cb0c23a95819329802d32d4) --- hadoop-common-project/hadoop-common/CHANGES.txt | 4 ++++ .../main/java/org/apache/hadoop/io/retry/RetryPolicies.java | 2 +- .../src/test/java/org/apache/hadoop/net/ServerSocketUtil.java | 2 +- .../java/org/apache/hadoop/yarn/conf/YarnConfiguration.java | 4 ++-- .../hadoop-yarn-common/src/main/resources/yarn-default.xml | 2 +- .../resourcemanager/amlauncher/ApplicationMasterLauncher.java | 4 ++-- 6 files changed, 11 insertions(+), 7 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index b873ba6d5cb..3f933b26b03 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -35,6 +35,10 @@ Release 2.8.0 - UNRELEASED IMPROVEMENTS + HADOOP-12458. Retries is typoed to spell Retires in parts of + hadoop-yarn and hadoop-common + (Neelesh Srinivas Salian via harsh) + HADOOP-12271. Hadoop Jar Error Should Be More Explanatory (Josh Elser via harsh) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java index 871a8bab194..f978ae75372 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java @@ -371,7 +371,7 @@ public class RetryPolicies { /** * Parse the given string as a MultipleLinearRandomRetry object. * The format of the string is "t_1, n_1, t_2, n_2, ...", - * where t_i and n_i are the i-th pair of sleep time and number of retires. + * where t_i and n_i are the i-th pair of sleep time and number of retries. * Note that the white spaces in the string are ignored. * * @return the parsed object, or null if the parsing fails. diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java index 19172876afb..3685162d795 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java @@ -34,7 +34,7 @@ public class ServerSocketUtil { * Port scan & allocate is how most other apps find ports * * @param port given port - * @param retries number of retires + * @param retries number of retries * @return * @throws IOException */ diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java index 848907f2237..3fbea1a1f48 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java @@ -153,9 +153,9 @@ public class YarnConfiguration extends Configuration { public static final int DEFAULT_RM_AMLAUNCHER_THREAD_COUNT = 50; /** Retry times to connect with NM.*/ - public static final String RM_NODEMANAGER_CONNECT_RETIRES = + public static final String RM_NODEMANAGER_CONNECT_RETRIES = RM_PREFIX + "nodemanager-connect-retries"; - public static final int DEFAULT_RM_NODEMANAGER_CONNECT_RETIRES = 10; + public static final int DEFAULT_RM_NODEMANAGER_CONNECT_RETRIES = 10; /** The Kerberos principal for the resource manager.*/ public static final String RM_PRINCIPAL = diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml index c8bca8ed728..f2e2f019190 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml @@ -1834,7 +1834,7 @@ - Default maximum number of retires for timeline servive client + Default maximum number of retries for timeline service client and value -1 means no limit. yarn.timeline-service.client.max-retries diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java index f606e45fdf4..0d172f4c1a4 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java @@ -68,8 +68,8 @@ public class ApplicationMasterLauncher extends AbstractService implements Configuration newConf = new YarnConfiguration(conf); newConf.setInt(CommonConfigurationKeysPublic. IPC_CLIENT_CONNECT_MAX_RETRIES_ON_SOCKET_TIMEOUTS_KEY, - conf.getInt(YarnConfiguration.RM_NODEMANAGER_CONNECT_RETIRES, - YarnConfiguration.DEFAULT_RM_NODEMANAGER_CONNECT_RETIRES)); + conf.getInt(YarnConfiguration.RM_NODEMANAGER_CONNECT_RETRIES, + YarnConfiguration.DEFAULT_RM_NODEMANAGER_CONNECT_RETRIES)); setConfig(newConf); super.serviceInit(newConf); }