From 21bc85558718490e558c5b3bdb44c9c64eada994 Mon Sep 17 00:00:00 2001 From: Xiao Chen Date: Mon, 16 Oct 2017 10:33:16 -0700 Subject: [PATCH] HDFS-12642. Log block and datanode details in BlockRecoveryWorker. --- .../hdfs/server/datanode/BlockRecoveryWorker.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java index 15c4af1a12e..2ecd986facc 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java @@ -197,10 +197,9 @@ void syncBlock(List syncList) throws IOException { long blockId = (isTruncateRecovery) ? rBlock.getNewBlock().getBlockId() : block.getBlockId(); - if (LOG.isDebugEnabled()) { - LOG.debug("block=" + block + ", (length=" + block.getNumBytes() - + "), syncList=" + syncList); - } + LOG.info("BlockRecoveryWorker: block={} (length={})," + + " isTruncateRecovery={}, syncList={}", block, + block.getNumBytes(), isTruncateRecovery, syncList); // syncList.isEmpty() means that all data-nodes do not have the block // or their replicas have 0 length. @@ -289,6 +288,11 @@ void syncBlock(List syncList) throws IOException { newBlock.setNumBytes(rBlock.getNewBlock().getNumBytes()); } + LOG.info("BlockRecoveryWorker: block={} (length={}), bestState={}," + + " newBlock={} (length={}), participatingList={}", + block, block.getNumBytes(), bestState.name(), newBlock, + newBlock.getNumBytes(), participatingList); + List failedList = new ArrayList<>(); final List successList = new ArrayList<>(); for (BlockRecord r : participatingList) { @@ -542,7 +546,7 @@ private static void logRecoverBlock(String who, RecoveringBlock rb) { ExtendedBlock block = rb.getBlock(); DatanodeInfo[] targets = rb.getLocations(); - LOG.info(who + " calls recoverBlock(" + block + LOG.info("BlockRecoveryWorker: " + who + " calls recoverBlock(" + block + ", targets=[" + Joiner.on(", ").join(targets) + "]" + ", newGenerationStamp=" + rb.getNewGenerationStamp() + ", newBlock=" + rb.getNewBlock()