From 229a3a23127e33f596d485dec580e31c48ba9057 Mon Sep 17 00:00:00 2001 From: Eli Collins Date: Sun, 27 Nov 2011 20:27:23 +0000 Subject: [PATCH] HADOOP-7858. Drop some info logging to DEBUG level in IPC, metrics, and HTTP. Contributed by Todd Lipcon git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1206830 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../main/java/org/apache/hadoop/http/HttpServer.java | 4 ++-- .../src/main/java/org/apache/hadoop/ipc/Server.java | 4 ++-- .../java/org/apache/hadoop/ipc/WritableRpcEngine.java | 2 +- .../apache/hadoop/metrics2/impl/MetricsSystemImpl.java | 10 +++++----- 5 files changed, 13 insertions(+), 10 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 139b8b1acd4..54829b2a9f8 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -123,6 +123,9 @@ Release 0.23.1 - Unreleased HADOOP-7802. Hadoop scripts unconditionally source "$bin"/../libexec/hadoop-config.sh. (Bruno Mahé via tomwhite) + HADOOP-7858. Drop some info logging to DEBUG level in IPC, + metrics, and HTTP. (todd via eli) + OPTIMIZATIONS BUG FIXES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java index e529e789edd..571a296fc9e 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java @@ -644,12 +644,12 @@ public class HttpServer implements FilterContainer { while (true) { try { port = webServer.getConnectors()[0].getLocalPort(); - LOG.info("Port returned by webServer.getConnectors()[0]." + + LOG.debug("Port returned by webServer.getConnectors()[0]." + "getLocalPort() before open() is "+ port + ". Opening the listener on " + oriPort); listener.open(); port = listener.getLocalPort(); - LOG.info("listener.getLocalPort() returned " + listener.getLocalPort() + + LOG.debug("listener.getLocalPort() returned " + listener.getLocalPort() + " webServer.getConnectors()[0].getLocalPort() returned " + webServer.getConnectors()[0].getLocalPort()); //Workaround to handle the problem reported in HADOOP-4744 diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java index 7fb53fe1cf7..0a778729663 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java @@ -1498,7 +1498,7 @@ public abstract class Server { @Override public void run() { - LOG.info(getName() + ": starting"); + LOG.debug(getName() + ": starting"); SERVER.set(Server.this); ByteArrayOutputStream buf = new ByteArrayOutputStream(INITIAL_RESP_BUF_SIZE); @@ -1580,7 +1580,7 @@ public abstract class Server { LOG.info(getName() + " caught an exception", e); } } - LOG.info(getName() + ": exiting"); + LOG.debug(getName() + ": exiting"); } } diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java index 48842237d4c..69538148914 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java @@ -389,7 +389,7 @@ public class WritableRpcEngine implements RpcEngine { } protocolImplMap.put(new ProtoNameVer(protocolName, version), new ProtoClassProtoImpl(protocolClass, protocolImpl)); - LOG.info("Protocol Name = " + protocolName + " version=" + version + + LOG.debug("Protocol Name = " + protocolName + " version=" + version + " ProtocolImpl=" + protocolImpl.getClass().getName() + " protocolClass=" + protocolClass.getName()); } diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java index d90ec743583..80189dc4b96 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java @@ -241,7 +241,7 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource { injectedTags, period, config.subset(SOURCE_KEY)); sources.put(name, sa); sa.start(); - LOG.info("Registered source "+ name); + LOG.debug("Registered source "+ name); } @Override public synchronized @@ -405,8 +405,8 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource { private synchronized void stopSources() { for (Entry entry : sources.entrySet()) { MetricsSourceAdapter sa = entry.getValue(); - LOG.info("Stopping metrics source "+ entry.getKey()); - LOG.debug(sa.source().getClass()); + LOG.debug("Stopping metrics source "+ entry.getKey() + + ": class=" + sa.source().getClass()); sa.stop(); } sysSource.stop(); @@ -416,8 +416,8 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource { private synchronized void stopSinks() { for (Entry entry : sinks.entrySet()) { MetricsSinkAdapter sa = entry.getValue(); - LOG.info("Stopping metrics sink "+ entry.getKey()); - LOG.debug(sa.sink().getClass()); + LOG.debug("Stopping metrics sink "+ entry.getKey() + + ": class=" + sa.sink().getClass()); sa.stop(); } sinks.clear();