From 2da46a4e7a339cb7dab8b4c5a1603c11299796ff Mon Sep 17 00:00:00 2001
From: Aaron Myers <atm@apache.org>
Date: Fri, 2 Mar 2012 01:38:56 +0000
Subject: [PATCH] HDFS-3038. Add FSEditLog.metrics to findbugs exclude list.
 Contributed by Todd Lipcon.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.23@1296021 13f79535-47bb-0310-9956-ffa450edef68
---
 hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt              | 2 ++
 .../hadoop-hdfs/dev-support/findbugsExcludeFile.xml      | 9 +++++++++
 2 files changed, 11 insertions(+)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
index 9d3b556fcdb..421a675ef55 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@@ -138,6 +138,8 @@ Release 0.23.3 - UNRELEASED
 
     HDFS-3020. Fix editlog to automatically sync when buffer is full. (todd)
 
+    HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. (todd via atm)
+
 Release 0.23.2 - UNRELEASED
 
   INCOMPATIBLE CHANGES
diff --git a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
index 9b5d6df12e4..709e52fb461 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
@@ -247,4 +247,13 @@
        <Method name="save" />
        <Bug pattern="OS_OPEN_STREAM" />
      </Match>
+     <!--
+      the 'metrics' member is sometimes used from synchronized blocks, sometimes not,
+      but it's only reset by test cases, so should be fine
+     -->
+     <Match>
+       <Class name="org.apache.hadoop.hdfs.server.namenode.FSEditLog" />
+       <Field name="metrics" />
+       <Bug pattern="IS2_INCONSISTENT_SYNC" />
+     </Match>
  </FindBugsFilter>