diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java index 038435c6c37..766fb0a6557 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java @@ -166,7 +166,7 @@ public int run(String argv[]) throws Exception { System.err.println("You must specify a host with -host."); return 1; } - if (args.size() < 0) { + if (args.isEmpty()) { System.err.println("You must specify an operation."); return 1; } diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java index ad20310d01f..5a4d2a3e8fa 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java @@ -77,6 +77,14 @@ private String getHostPortForDN(MiniDFSCluster cluster, int index) { return "127.0.0.1:" + dns.get(index).getIpcPort(); } + @Test + public void testNoOperator() throws Exception { + TraceAdmin trace = new TraceAdmin(); + trace.setConf(new Configuration()); + Assert.assertEquals("ret:1, You must specify an operation." + NEWLINE, + runTraceCommand(trace, "-host", "127.0.0.1:12346")); + } + @Test public void testCreateAndDestroySpanReceiver() throws Exception { Configuration conf = new Configuration();