HDFS-9515. NPE when MiniDFSCluster#shutdown is invoked on uninitialized reference. (Contributed by Wei-Chiu Chuang)

2015-12-17 13:43:27 -08:00 · 2015-12-17 13:43:27 -08:00 · 2f623fb8cc
parent db37f02dc7
commit 2f623fb8cc
152 changed files with 336 additions and 68 deletions
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@ -2510,6 +2510,9 @@ Release 2.8.0 - UNRELEASED
    HDFS-9570. Minor typos, grammar, and case sensitivity cleanup in
    HdfsPermissionsGuide.md's (Travis Campbell via aw)

+    HDFS-9515. NPE when MiniDFSCluster#shutdown is invoked on uninitialized
+    reference. (Wei-Chiu Chuang via Arpit Agarwal)
+
 Release 2.7.3 - UNRELEASED

  INCOMPATIBLE CHANGES
--- a/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBootstrapStandbyWithBKJM.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBootstrapStandbyWithBKJM.java
@ -63,6 +63,7 @@ public class TestBootstrapStandbyWithBKJM {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/TestRefreshCallQueue.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/TestRefreshCallQueue.java
@ -86,6 +86,7 @@ public class TestRefreshCallQueue {
  public void tearDown() throws Exception {
    if(cluster!=null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestAclCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestAclCLI.java
@ -49,9 +49,11 @@ public class TestAclCLI extends CLITestHelperDFS {
    super.tearDown();
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestCacheAdminCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestCacheAdminCLI.java
@ -76,9 +76,11 @@ public class TestCacheAdminCLI extends CLITestHelper {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestCryptoAdminCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestCryptoAdminCLI.java
@ -86,9 +86,11 @@ public class TestCryptoAdminCLI extends CLITestHelperDFS {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestDeleteCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestDeleteCLI.java
@ -58,9 +58,11 @@ public class TestDeleteCLI extends CLITestHelperDFS {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestErasureCodingCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestErasureCodingCLI.java
@ -61,9 +61,11 @@ public class TestErasureCodingCLI extends CLITestHelper {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
@ -77,9 +77,11 @@ public class TestHDFSCLI extends CLITestHelperDFS {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestXAttrCLI.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestXAttrCLI.java
@ -67,9 +67,11 @@ public class TestXAttrCLI  extends CLITestHelperDFS {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (dfsCluster != null) {
      dfsCluster.shutdown();
+      dfsCluster = null;
    }
    Thread.sleep(2000);
    super.tearDown();
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsCreateMkdir.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsCreateMkdir.java
@ -58,8 +58,10 @@ public class TestFcHdfsCreateMkdir extends
      
  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
  
  @Override
  @Before
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsPermission.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsPermission.java
@ -65,8 +65,10 @@ public class TestFcHdfsPermission extends FileContextPermissionBase {
      
  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
  
  @Override
  @Before
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java
@ -96,8 +96,10 @@ public class TestFcHdfsSetUMask {

  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
  
  {
    try {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfs.java
@ -96,8 +96,10 @@ abstract public class TestSymlinkHdfs extends SymlinkBaseTest {

  @AfterClass
  public static void afterClassTeardown() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Test(timeout=10000)
  /** Access a file using a link that spans Hdfs to LocalFs */
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/contract/hdfs/HDFSContract.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/contract/hdfs/HDFSContract.java
@ -62,6 +62,7 @@ public class HDFSContract extends AbstractFSContract {
  public static void destroyCluster() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/shell/TestHdfsTextCommand.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/shell/TestHdfsTextCommand.java
@ -60,9 +60,11 @@ public class TestHdfsTextCommand {
    public void tearDown() throws IOException{
    if(fs != null){
      fs.close();
+      fs = null;
    }
    if(cluster != null){
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
@ -88,8 +88,10 @@ public class TestViewFileSystemHdfs extends ViewFileSystemBaseTest {
      
  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Override
  @Before
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithAcls.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithAcls.java
@ -76,8 +76,10 @@ public class TestViewFileSystemWithAcls {

  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Before
  public void setUp() throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithXAttrs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithXAttrs.java
@ -71,8 +71,10 @@ public class TestViewFileSystemWithXAttrs {

  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Before
  public void setUp() throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsAtHdfsRoot.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsAtHdfsRoot.java
@ -64,8 +64,10 @@ public class TestViewFsAtHdfsRoot extends ViewFsBaseTest {
      
  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Override
  @Before
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsHdfs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsHdfs.java
@ -64,8 +64,10 @@ public class TestViewFsHdfs extends ViewFsBaseTest {
      
  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Override
  @Before
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsWithAcls.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsWithAcls.java
@ -76,8 +76,10 @@ public class TestViewFsWithAcls {

  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Before
  public void setUp() throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsWithXAttrs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsWithXAttrs.java
@ -70,8 +70,10 @@ public class TestViewFsWithXAttrs {

  @AfterClass
  public static void ClusterShutdownAtEnd() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  @Before
  public void setUp() throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/FileAppendTest4.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/FileAppendTest4.java
@ -68,8 +68,10 @@ public class FileAppendTest4 {

  @AfterClass
  public static void tearDown() {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
  
  /**
   * Comprehensive test for append 
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAbandonBlock.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAbandonBlock.java
@ -56,8 +56,14 @@ public class TestAbandonBlock {

  @After
  public void tearDown() throws Exception {
+    if (fs != null) {
      fs.close();
+      fs = null;
+    }
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  @Test
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlocksScheduledCounter.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlocksScheduledCounter.java
@ -43,9 +43,11 @@ public class TestBlocksScheduledCounter {
  public void tearDown() throws IOException {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if(cluster!=null){
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestClientReportBadBlock.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestClientReportBadBlock.java
@ -82,8 +82,14 @@ public class TestClientReportBadBlock {

  @After
  public void shutDownCluster() throws IOException {
+    if (dfs != null) {
      dfs.close();
+      dfs = null;
+    }
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  /*
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientExcludedNodes.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientExcludedNodes.java
@ -54,6 +54,7 @@ public class TestDFSClientExcludedNodes {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientFailover.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientFailover.java
@ -88,6 +88,7 @@ public class TestDFSClientFailover {
  public void tearDownCluster() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientSocketSize.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientSocketSize.java
@ -82,6 +82,7 @@ public class TestDFSClientSocketSize {
    if (cluster != null) {
      LOG.info("Shutting down MiniDFSCluster.");
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSFinalize.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSFinalize.java
@ -188,7 +188,10 @@ public class TestDFSFinalize {
  @After
  public void tearDown() throws Exception {
    LOG.info("Shutting down MiniDFSCluster");
-    if (cluster != null) cluster.shutdown();
+    if (cluster != null) {
+      cluster.shutdown();
+      cluster = null;
+    }
  }
  
  public static void main(String[] args) throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSOutputStream.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSOutputStream.java
@ -150,6 +150,8 @@ public class TestDFSOutputStream {

  @AfterClass
  public static void tearDown() {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
 }
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
@ -123,6 +123,7 @@ public class TestDFSPermission {
  public void tearDown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRollback.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRollback.java
@ -346,7 +346,10 @@ public class TestDFSRollback {
  @After
  public void tearDown() throws Exception {
    LOG.info("Shutting down MiniDFSCluster");
-    if (cluster != null) cluster.shutdown();
+    if (cluster != null) {
+      cluster.shutdown();
+      cluster = null;
+    }
  }
  
  public static void main(String[] args) throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStartupVersions.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStartupVersions.java
@ -282,7 +282,10 @@ public class TestDFSStartupVersions {
  @After
  public void tearDown() throws Exception {
    LOG.info("Shutting down MiniDFSCluster");
-    if (cluster != null) cluster.shutdown();
+    if (cluster != null) {
+      cluster.shutdown();
+      cluster = null;
+    }
  }
  
  public static void main(String[] args) throws Exception {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
@ -452,6 +452,9 @@ public class TestDFSStorageStateRecovery {
  @After
  public void tearDown() throws Exception {
    LOG.info("Shutting down MiniDFSCluster");
-    if (cluster != null) cluster.shutdown();
+    if (cluster != null) {
+      cluster.shutdown();
+      cluster = null;
+    }
  }
 }
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java
@ -86,6 +86,7 @@ public class TestDFSStripedInputStream {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
@ -69,6 +69,7 @@ public class TestDFSStripedOutputStream {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferKeepalive.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferKeepalive.java
@ -69,7 +69,10 @@ public class TestDataTransferKeepalive {
  
  @After
  public void teardown() {
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }
  
  /**
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
@ -126,6 +126,7 @@ public class TestDecommission {
    cleanupFile(localFileSys, dir);
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
@ -170,6 +170,7 @@ public class TestEncryptionZones {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
    EncryptionFaultInjector.instance = new EncryptionFaultInjector();
  }
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithHA.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithHA.java
@ -87,6 +87,7 @@ public class TestEncryptionZonesWithHA {
  public void shutdownCluster() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java
@ -61,6 +61,7 @@ public class TestErasureCodingPolicies {
  public void shutdownCluster() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java
@ -57,6 +57,7 @@ public class TestErasureCodingPolicyWithSnapshot {
  public void shutdownCluster() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
@ -84,9 +84,11 @@ public class TestFileConcurrentReader {

  @After
  public void tearDown() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
      cluster = null;
    }
+  }

  private void init(Configuration conf) throws IOException {
    if (cluster != null) {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileStatus.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileStatus.java
@ -77,9 +77,13 @@ public class TestFileStatus {
  
  @AfterClass
  public static void testTearDown() throws Exception {
+    if (fs != null) {
      fs.close();
+    }
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }
  
  private void checkFile(FileSystem fileSys, Path name, int repl)
      throws IOException, InterruptedException, TimeoutException {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileStatusWithECPolicy.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileStatusWithECPolicy.java
@ -50,6 +50,7 @@ public class TestFileStatusWithECPolicy {
  public void after() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestGetFileChecksum.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestGetFileChecksum.java
@ -52,6 +52,7 @@ public class TestGetFileChecksum {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSFileSystemContract.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSFileSystemContract.java
@ -45,9 +45,11 @@ public class TestHDFSFileSystemContract extends FileSystemContractBaseTest {
  @Override
  protected void tearDown() throws Exception {
    super.tearDown();
+    if (cluster != null) {
      cluster.shutdown();
      cluster = null;
    }
+  }

  @Override
  protected String getDefaultWorkingDirectory() {
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHdfsAdmin.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHdfsAdmin.java
@ -47,6 +47,7 @@ public class TestHdfsAdmin {
  public void shutDownCluster() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
@ -57,6 +57,7 @@ public class TestLeaseRecovery {
  public void shutdown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java
@ -101,8 +101,10 @@ public class TestLeaseRecovery2 {
   */
  @AfterClass
  public static void tearDown() throws IOException {
+    if (cluster != null) {
      IOUtils.closeStream(dfs);
-    if (cluster != null) {cluster.shutdown();}
+      cluster.shutdown();
+    }
  }

  /**
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInDFS.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInDFS.java
@ -46,9 +46,11 @@ public class TestListFilesInDFS extends TestListFiles {
  
  @AfterClass
  public static void testShutdown() throws Exception {
+    if (cluster != null) {
      fs.close();
      cluster.shutdown();
    }
+  }
  
  protected static Path getTestDir() {
    return new Path("/main_");
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
@ -83,8 +83,10 @@ public class TestListFilesInFileContext {
  
  @AfterClass
  public static void testShutdown() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  /** Test when input path is a file */
  @Test
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPipelines.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPipelines.java
@ -65,11 +65,14 @@ public class TestPipelines {

  @After
  public void shutDownCluster() throws IOException {
-    if (fs != null)
+    if (fs != null) {
      fs.close();
+      fs = null;
+    }
    if (cluster != null) {
      cluster.shutdownDataNodes();
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithDecoding.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithDecoding.java
@ -77,6 +77,7 @@ public class TestReadStripedFileWithDecoding {
  public void tearDown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithMissingBlocks.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithMissingBlocks.java
@ -61,6 +61,7 @@ public class TestReadStripedFileWithMissingBlocks {
  public void tearDown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRecoverStripedFile.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRecoverStripedFile.java
@ -97,6 +97,7 @@ public class TestRecoverStripedFile {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReservedRawPaths.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReservedRawPaths.java
@ -91,6 +91,7 @@ public class TestReservedRawPaths {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java
@ -90,9 +90,11 @@ public class TestSafeMode {
  public void tearDown() throws IOException {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeModeWithStripedFile.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeModeWithStripedFile.java
@ -63,6 +63,7 @@ public class TestSafeModeWithStripedFile {
  public void tearDown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestWriteRead.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestWriteRead.java
@ -86,7 +86,10 @@ public class TestWriteRead {

  @After
  public void shutdown() {
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  // Equivalence of @Before for cluster mode testing.
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestWriteReadStripedFile.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestWriteReadStripedFile.java
@ -76,6 +76,7 @@ public class TestWriteReadStripedFile {
  public void tearDown() throws IOException {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/TestSaslDataTransfer.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/TestSaslDataTransfer.java
@ -67,6 +67,7 @@ public class TestSaslDataTransfer extends SaslDataTransferTestCase {
    IOUtils.cleanup(null, fs);
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestSecureNNWithQJM.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestSecureNNWithQJM.java
@ -154,9 +154,11 @@ public class TestSecureNNWithQJM {
    IOUtils.cleanup(null, fs);
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
    if (mjc != null) {
      mjc.shutdown();
+      mjc = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java
@ -114,6 +114,7 @@ public class TestQuorumJournalManager {
    
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNodeMXBean.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNodeMXBean.java
@ -61,6 +61,7 @@ public class TestJournalNodeMXBean {
  public void cleanup() throws IOException {
    if (jCluster != null) {
      jCluster.shutdown();
+      jCluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
@ -84,6 +84,7 @@ public class TestDelegationToken {
  public void tearDown() throws Exception {
    if(cluster!=null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
@ -67,6 +67,7 @@ public class TestBlockStatsMXBean {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java
@ -70,6 +70,7 @@ public class TestComputeInvalidateWork {
  public void teardown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
@ -74,6 +74,7 @@ public class TestPendingInvalidateBlock {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockGroupId.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockGroupId.java
@ -93,6 +93,7 @@ public class TestSequentialBlockGroupId {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/BlockReportTestBase.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/BlockReportTestBase.java
@ -115,10 +115,12 @@ public abstract class BlockReportTestBase {
  public void shutDownCluster() throws IOException {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (cluster != null) {
      cluster.shutdownDataNodes();
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeExit.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeExit.java
@ -59,8 +59,10 @@ public class TestDataNodeExit {

  @After
  public void tearDown() throws Exception {
-    if (cluster != null)
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }
  
  private void stopBPServiceThreads(int numStopThreads, DataNode dn)
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
@ -116,12 +116,15 @@ public class TestDataNodeVolumeFailure {
  public void tearDown() throws Exception {
    if(data_fail != null) {
      FileUtil.setWritable(data_fail, true);
+      data_fail = null;
    }
    if(failedDir != null) {
      FileUtil.setWritable(failedDir, true);
+      failedDir = null;
    }
    if(cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
@ -89,6 +89,7 @@ public class TestDataNodeVolumeFailureReporting {
    IOUtils.cleanup(LOG, fs);
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
@ -78,6 +78,7 @@ public class TestDataNodeVolumeFailureToleration {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java
@ -71,7 +71,10 @@ public class TestDiskError {

  @After
  public void tearDown() throws Exception {
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  /**
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCache.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCache.java
@ -149,9 +149,11 @@ public class TestFsDatasetCache {
    DFSTestUtil.verifyExpectedCacheUsage(0, 0, fsd);
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
    // Restore the original CacheManipulator
    NativeIO.POSIX.setCacheManipulator(prevCacheManipulator);
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBrVariations.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBrVariations.java
@ -101,10 +101,13 @@ public class TestIncrementalBrVariations {

  @After
  public void shutDownCluster() throws IOException {
+    if (cluster != null) {
      client.close();
      fs.close();
      cluster.shutdownDataNodes();
      cluster.shutdown();
+      cluster = null;
+    }
  }

  /**
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclConfigFlag.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclConfigFlag.java
@ -58,6 +58,7 @@ public class TestAclConfigFlag {
    IOUtils.cleanup(null, fs);
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlock.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlock.java
@ -60,6 +60,7 @@ public class TestAddBlock {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }
  
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlockRetry.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlockRetry.java
@ -66,6 +66,7 @@ public class TestAddBlockRetry {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddOverReplicatedStripedBlocks.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddOverReplicatedStripedBlocks.java
@ -75,6 +75,7 @@ public class TestAddOverReplicatedStripedBlocks {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddStripedBlocks.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddStripedBlocks.java
@ -82,6 +82,7 @@ public class TestAddStripedBlocks {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogs.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLogs.java
@ -137,8 +137,14 @@ public class TestAuditLogs {
  @After
  public void teardownCluster() throws Exception {
    util.cleanup(fs, "/srcdat");
+    if (fs != null) {
      fs.close();
+      fs = null;
+    }
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  /** test that allowed operation puts proper entry in audit log */
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
@ -494,9 +494,11 @@ public class TestBackupNode {
      assertTrue(e.getLocalizedMessage(), false);
    } finally {
      fileSys.close();
+      if (cluster != null) {
        cluster.shutdown();
      }
    }
+  }

  /**
   * Verify that a file can be read both from NameNode and BackupNode.
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBlockPlacementPolicyRackFaultTolerant.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBlockPlacementPolicyRackFaultTolerant.java
@ -83,6 +83,7 @@ public class TestBlockPlacementPolicyRackFaultTolerant {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
@ -158,6 +158,7 @@ public class TestCacheDirectives {
    waitForCachedBlocks(namenode, 0, 0, "teardown");
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
    // Restore the original CacheManipulator
    NativeIO.POSIX.setCacheManipulator(prevCacheManipulator);
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockWithInvalidGenStamp.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockWithInvalidGenStamp.java
@ -58,6 +58,7 @@ public class TestCommitBlockWithInvalidGenStamp {
  public void tearDown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
@ -62,7 +62,10 @@ public class TestDeadDatanode {

  @After
  public void cleanup() {
+    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
+    }
  }

  /**
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDefaultBlockPlacementPolicy.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDefaultBlockPlacementPolicy.java
@ -71,6 +71,7 @@ public class TestDefaultBlockPlacementPolicy {
  public void teardown() {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDiskspaceQuotaUpdate.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDiskspaceQuotaUpdate.java
@ -71,6 +71,7 @@ public class TestDiskspaceQuotaUpdate {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogAutoroll.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogAutoroll.java
@ -97,9 +97,11 @@ public class TestEditLogAutoroll {
  public void tearDown() throws Exception {
    if (fs != null) {
      fs.close();
+      fs = null;
    }
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogJournalFailures.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogJournalFailures.java
@ -70,11 +70,14 @@ public class TestEditLogJournalFailures {
  
  @After
  public void shutDownMiniCluster() throws IOException {
-    if (fs != null)
+    if (fs != null) {
      fs.close();
+      fs = null;
+    }
    if (cluster != null) {
      try {
        cluster.shutdown();
+        cluster = null;
      } catch (ExitException ee) {
        // Ignore ExitExceptions as the tests may result in the
        // NameNode doing an immediate shutdown.
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirectory.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSDirectory.java
@ -108,6 +108,7 @@ public class TestFSDirectory {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithAcl.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithAcl.java
@ -55,8 +55,10 @@ public class TestFSImageWithAcl {

  @AfterClass
  public static void tearDown() {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  private void testAcl(boolean persistNamespace) throws IOException {
    Path p = new Path("/p");
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithSnapshot.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithSnapshot.java
@ -89,6 +89,7 @@ public class TestFSImageWithSnapshot {
  public void tearDown() throws Exception {
    if (cluster != null) {
      cluster.shutdown();
+      cluster = null;
    }
  }

--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithXAttr.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithXAttr.java
@ -62,8 +62,10 @@ public class TestFSImageWithXAttr {

  @AfterClass
  public static void tearDown() {
+    if (cluster != null) {
      cluster.shutdown();
    }
+  }

  private void testXAttr(boolean persistNamespace) throws IOException {
    Path path = new Path("/p");
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
@ -110,8 +110,14 @@ public class TestFileTruncate {

  @After
  public void tearDown() throws IOException {
-    if(fs != null)      fs.close();
-    if(cluster != null) cluster.shutdown();
+    if(fs != null) {
+      fs.close();
+      fs = null;
+    }
+    if(cluster != null) {
+      cluster.shutdown();
+      cluster = null;
+    }
  }

  /**
--- a/Show More
+++ b/Show More