diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index b78cb2717d1..ff3de54fda9 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -11,6 +11,8 @@ Release 0.23-PB - Unreleased HDFS-2351 Change Namenode and Datanode to register each of their protocols seperately (Sanjay Radia) + HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm) + Release 0.23.1 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java index 19d696ac457..f242cc83f65 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java @@ -123,7 +123,6 @@ public class DFSClient implements java.io.Closeable { public static final long SERVER_DEFAULTS_VALIDITY_PERIOD = 60 * 60 * 1000L; // 1 hour static final int TCP_WINDOW_SIZE = 128 * 1024; // 128 KB final ClientProtocol namenode; - final ClientProtocol rpcNamenode; private final InetSocketAddress nnAddress; final UserGroupInformation ugi; volatile boolean clientRunning = true; @@ -291,11 +290,10 @@ public class DFSClient implements java.io.Closeable { this.clientName = leaserenewer.getClientName(dfsClientConf.taskId); this.socketCache = new SocketCache(dfsClientConf.socketCacheCapacity); if (nameNodeAddr != null && rpcNamenode == null) { - this.rpcNamenode = DFSUtil.createRPCNamenode(nameNodeAddr, conf, ugi); - this.namenode = DFSUtil.createNamenode(this.rpcNamenode); + this.namenode = DFSUtil.createNamenode(nameNodeAddr, conf); } else if (nameNodeAddr == null && rpcNamenode != null) { //This case is used for testing. - this.namenode = this.rpcNamenode = rpcNamenode; + this.namenode = rpcNamenode; } else { throw new IllegalArgumentException( "Expecting exactly one of nameNodeAddr and rpcNamenode being null: " @@ -385,7 +383,7 @@ public class DFSClient implements java.io.Closeable { void abort() { clientRunning = false; closeAllFilesBeingWritten(true); - RPC.stopProxy(rpcNamenode); // close connections to the namenode + RPC.stopProxy(namenode); // close connections to the namenode } /** Close/abort all files being written. */ @@ -425,7 +423,7 @@ public class DFSClient implements java.io.Closeable { clientRunning = false; leaserenewer.closeClient(this); // close connections to the namenode - RPC.stopProxy(rpcNamenode); + RPC.stopProxy(namenode); } }