HDFS-12558. Ozone: Clarify the meaning of rpc.metrics.percentiles.intervals on KSM/SCM web ui. Contributed by Elek, Marton.

This commit is contained in:
Anu Engineer 2017-10-26 11:36:34 -07:00 committed by Owen O'Malley
parent 333dae888c
commit 338c909ac6
2 changed files with 12 additions and 9 deletions

View File

@ -112,8 +112,8 @@
var createPercentageMetrics = function (metricName, window) { var createPercentageMetrics = function (metricName, window) {
groupedMetrics.percentiles = groupedMetrics['percentiles'] || {} groupedMetrics.percentiles = groupedMetrics['percentiles'] || {}
groupedMetrics.percentiles[metricName] = groupedMetrics.percentiles[metricName] || {}; groupedMetrics.percentiles[window] = groupedMetrics.percentiles[window] || {};
groupedMetrics.percentiles[metricName][window] = groupedMetrics.percentiles[metricName][window] || { groupedMetrics.percentiles[window][metricName] = groupedMetrics.percentiles[window][metricName] || {
graphdata: [{ graphdata: [{
key: window, key: window,
values: [] values: []
@ -134,7 +134,7 @@
createPercentageMetrics(metricName, window); createPercentageMetrics(metricName, window);
groupedMetrics.percentiles[metricName][window].graphdata[0] groupedMetrics.percentiles[window][metricName].graphdata[0]
.values.push({ .values.push({
label: percentage, label: percentage,
value: metrics[key] value: metrics[key]
@ -169,7 +169,7 @@
var metricName = percentileNumOps[1]; var metricName = percentileNumOps[1];
var window = percentileNumOps[2]; var window = percentileNumOps[2];
createPercentageMetrics(metricName, window); createPercentageMetrics(metricName, window);
groupedMetrics.percentiles[metricName][window].numOps = metrics[key]; groupedMetrics.percentiles[window][metricName].numOps = metrics[key];
} else if (isIgnoredJmxKeys(key)) { } else if (isIgnoredJmxKeys(key)) {
//ignore //ignore
} else { } else {

View File

@ -20,14 +20,17 @@
(eg. set to <b>60,300</b>) in your hdfs-site.xml (eg. set to <b>60,300</b>) in your hdfs-site.xml
to display Hadoop RPC related graphs. to display Hadoop RPC related graphs.
</div> </div>
<div ng-repeat="(metric,percentiles) in $ctrl.metrics.percentiles"> <div ng-repeat="(window,windowed) in $ctrl.metrics.percentiles">
<h2>{{metric}}</h2> <h2>{{window}} window</h2>
<p>Quantiles based on a fixed {{window}} window. Calculated once at every
{{window}}</p>
<div class="container"> <div class="container">
<div class="col-md-6" ng-repeat="(window,windowed) in percentiles"> <div class="col-md-6" ng-repeat="(metric,percentiles) in windowed">
<h3>{{window}} window ({{windowed.numOps}} request)</h3> <h3>{{metric}}</h3>
<p>{{percentiles.numOps}} sample</p>
<nvd3 options="$ctrl.percentileGraphOptions" <nvd3 options="$ctrl.percentileGraphOptions"
data="windowed.graphdata"></nvd3> data="percentiles.graphdata"></nvd3>
</div> </div>
</div> </div>