From 371452e26005a483b069cc8d558ec1b4eb6f2e0e Mon Sep 17 00:00:00 2001 From: Prabhu Joseph Date: Fri, 21 Jun 2019 17:02:54 -0700 Subject: [PATCH] HADOOP-15989. Synchronized at CompositeService#removeService is not required. Contributed by Prabhu Joseph. Signed-off-by: Wei-Chiu Chuang --- .../main/java/org/apache/hadoop/service/CompositeService.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java index a5e8c895c65..4aa2f23fad7 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java @@ -93,7 +93,8 @@ protected boolean addIfService(Object object) { } } - protected synchronized boolean removeService(Service service) { + protected boolean removeService(Service service) { + LOG.debug("Removing service {}", service.getName()); synchronized (serviceList) { return serviceList.remove(service); }