Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-7962. Remove duplicated logs in BlockManager. (yliu)

This commit is contained in:
yliu 2015-03-20 05:31:08 +08:00
parent 3f0c9e5fe3
commit 3fac95f48d
2 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -462,6 +462,8 @@ Release 2.7.0 - UNRELEASED
HDFS.7849. Update documentation for enabling a new feature in rolling HDFS.7849. Update documentation for enabling a new feature in rolling
upgrade ( J.Andreina via vinayakumarb ) upgrade ( J.Andreina via vinayakumarb )
HDFS-7962. Remove duplicated logs in BlockManager. (yliu)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-7454. Reduce memory footprint for AclEntries in NameNode. HDFS-7454. Reduce memory footprint for AclEntries in NameNode.

21
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
View File

@ -365,10 +365,10 @@ public class BlockManager {
if (!isEnabled) { if (!isEnabled) {
if (UserGroupInformation.isSecurityEnabled()) { if (UserGroupInformation.isSecurityEnabled()) {
LOG.error("Security is enabled but block access tokens " + LOG.error("Security is enabled but block access tokens " +
"(via " + DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_ENABLE_KEY + ") " + "(via " + DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_ENABLE_KEY + ") " +
"aren't enabled. This may cause issues " + "aren't enabled. This may cause issues " +
"when clients attempt to talk to a DataNode."); "when clients attempt to talk to a DataNode.");
} }
return null; return null;
} }
@ -1222,10 +1222,6 @@ public class BlockManager {
// Check how many copies we have of the block // Check how many copies we have of the block
NumberReplicas nr = countNodes(b.stored); NumberReplicas nr = countNodes(b.stored);
if (nr.replicasOnStaleNodes() > 0) { if (nr.replicasOnStaleNodes() > 0) {
blockLog.info("BLOCK* invalidateBlocks: postponing " +
"invalidation of " + b + " on " + dn + " because " +
nr.replicasOnStaleNodes() + " replica(s) are located on nodes " +
"with potentially out-of-date block reports");
blockLog.info("BLOCK* invalidateBlocks: postponing " + blockLog.info("BLOCK* invalidateBlocks: postponing " +
"invalidation of {} on {} because {} replica(s) are located on " + "invalidation of {} on {} because {} replica(s) are located on " +
"nodes with potentially out-of-date block reports", b, dn, "nodes with potentially out-of-date block reports", b, dn,
@ -1499,8 +1495,10 @@ public class BlockManager {
} }
} }
} }
blockLog.debug("BLOCK* neededReplications = {} pendingReplications = {}", if (blockLog.isDebugEnabled()) {
neededReplications.size(), pendingReplications.size()); blockLog.debug("BLOCK* neededReplications = {} pendingReplications = {}",
neededReplications.size(), pendingReplications.size());
}
return scheduledWork; return scheduledWork;
} }
@ -2480,9 +2478,6 @@ public class BlockManager {
} }
} else if (result == AddBlockResult.REPLACED) { } else if (result == AddBlockResult.REPLACED) {
curReplicaDelta = 0; curReplicaDelta = 0;
blockLog.warn("BLOCK* addStoredBlock: " + "block " + storedBlock
+ " moved to storageType " + storageInfo.getStorageType()
+ " on node " + node);
blockLog.warn("BLOCK* addStoredBlock: block {} moved to storageType " + blockLog.warn("BLOCK* addStoredBlock: block {} moved to storageType " +
"{} on node {}", storedBlock, storageInfo.getStorageType(), node); "{} on node {}", storedBlock, storageInfo.getStorageType(), node);
} else { } else {