YARN-7296. convertToProtoFormat(Resource r) is not setting for all resource types. Contributed by lovekesh bansal.

This commit is contained in:
Sunil G 2017-10-10 12:02:18 +05:30
parent 5cfbad68c0
commit 41351b05f3
3 changed files with 7 additions and 15 deletions

View File

@ -22,6 +22,7 @@
import org.apache.hadoop.classification.InterfaceStability;
import org.apache.hadoop.yarn.api.protocolrecords.GetAllResourceProfilesResponse;
import org.apache.hadoop.yarn.api.records.Resource;
import org.apache.hadoop.yarn.api.records.impl.pb.ProtoUtils;
import org.apache.hadoop.yarn.api.records.impl.pb.ResourcePBImpl;
import org.apache.hadoop.yarn.proto.YarnProtos.ResourceProto;
import org.apache.hadoop.yarn.proto.YarnProtos.ResourceProfilesProto;
@ -129,9 +130,6 @@ private void initResourceProfiles() {
}
private ResourceProto convertToProtoFormat(Resource res) {
ResourcePBImpl r = new ResourcePBImpl();
r.setMemorySize(res.getMemorySize());
r.setVirtualCores(res.getVirtualCores());
return r.getProto();
return ProtoUtils.convertToProtoFormat(res);
}
}

View File

@ -22,10 +22,10 @@
import org.apache.hadoop.classification.InterfaceStability;
import org.apache.hadoop.yarn.api.protocolrecords.GetResourceProfileResponse;
import org.apache.hadoop.yarn.api.records.Resource;
import org.apache.hadoop.yarn.api.records.impl.pb.ResourcePBImpl;
import org.apache.hadoop.yarn.api.records.impl.pb.ProtoUtils;
import org.apache.hadoop.yarn.proto.YarnProtos.ResourceProto;
import org.apache.hadoop.yarn.proto.YarnServiceProtos.GetResourceProfileResponseProtoOrBuilder;
import org.apache.hadoop.yarn.proto.YarnServiceProtos.GetResourceProfileResponseProto;
import org.apache.hadoop.yarn.proto.YarnServiceProtos.GetResourceProfileResponseProtoOrBuilder;
import org.apache.hadoop.yarn.util.resource.Resources;
/**
@ -92,10 +92,7 @@ private void mergeLocalToBuilder() {
}
private ResourceProto convertToProtoFormat(Resource res) {
ResourcePBImpl r = new ResourcePBImpl();
r.setMemorySize(res.getMemorySize());
r.setVirtualCores(res.getVirtualCores());
return r.getProto();
return ProtoUtils.convertToProtoFormat(res);
}
private void maybeInitBuilder() {

View File

@ -23,8 +23,8 @@
import org.apache.hadoop.yarn.api.records.ProfileCapability;
import org.apache.hadoop.yarn.api.records.Resource;
import org.apache.hadoop.yarn.proto.YarnProtos;
import org.apache.hadoop.yarn.proto.YarnProtos.ProfileCapabilityProtoOrBuilder;
import org.apache.hadoop.yarn.proto.YarnProtos.ProfileCapabilityProto;
import org.apache.hadoop.yarn.proto.YarnProtos.ProfileCapabilityProtoOrBuilder;
import org.apache.hadoop.yarn.util.resource.Resources;
/**
@ -121,9 +121,6 @@ private void maybeInitBuilder() {
}
private YarnProtos.ResourceProto convertToProtoFormat(Resource res) {
ResourcePBImpl r = new ResourcePBImpl();
r.setMemorySize(res.getMemorySize());
r.setVirtualCores(res.getVirtualCores());
return r.getProto();
return ProtoUtils.convertToProtoFormat(res);
}
}