Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-10688. Expose thread-level FileSystem StatisticsData (Sandy Ryza) 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1602516 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sanford Ryza 2014-06-13 20:45:24 +00:00
parent 70db2ec417
commit 41eca36855
2 changed files with 29 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -425,6 +425,8 @@ Release 2.5.0 - UNRELEASED
HADOOP-10691. Improve the readability of 'hadoop fs -help'.
(Lei Xu via wang)
HADOOP-10688. Expose thread-level FileSystem StatisticsData (Sandy Ryza)
OPTIMIZATIONS
BUG FIXES

34
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
View File

@ -2804,7 +2804,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* be perceived as atomic with respect to other threads, which is all we
* need.
*/
private static class StatisticsData {
public static class StatisticsData {
volatile long bytesRead;
volatile long bytesWritten;
volatile int readOps;
@ -2849,6 +2849,26 @@ public abstract class FileSystem extends Configured implements Closeable {
+ readOps + " read ops, " + largeReadOps + " large read ops, "
+ writeOps + " write ops";
}
public long getBytesRead() {
return bytesRead;
}
public long getBytesWritten() {
return bytesWritten;
}
public int getReadOps() {
return readOps;
}
public int getLargeReadOps() {
return largeReadOps;
}
public int getWriteOps() {
return writeOps;
}
}
private interface StatisticsAggregator<T> {
@ -2907,7 +2927,7 @@ public abstract class FileSystem extends Configured implements Closeable {
/**
* Get or create the thread-local data associated with the current thread.
*/
private StatisticsData getThreadData() {
public StatisticsData getThreadStatistics() {
StatisticsData data = threadData.get();
if (data == null) {
data = new StatisticsData(
@ -2928,7 +2948,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* @param newBytes the additional bytes read
*/
public void incrementBytesRead(long newBytes) {
getThreadData().bytesRead += newBytes;
getThreadStatistics().bytesRead += newBytes;
}
/**
@ -2936,7 +2956,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* @param newBytes the additional bytes written
*/
public void incrementBytesWritten(long newBytes) {
getThreadData().bytesWritten += newBytes;
getThreadStatistics().bytesWritten += newBytes;
}
/**
@ -2944,7 +2964,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* @param count number of read operations
*/
public void incrementReadOps(int count) {
getThreadData().readOps += count;
getThreadStatistics().readOps += count;
}
/**
@ -2952,7 +2972,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* @param count number of large read operations
*/
public void incrementLargeReadOps(int count) {
getThreadData().largeReadOps += count;
getThreadStatistics().largeReadOps += count;
}
/**
@ -2960,7 +2980,7 @@ public abstract class FileSystem extends Configured implements Closeable {
* @param count number of write operations
*/
public void incrementWriteOps(int count) {
getThreadData().writeOps += count;
getThreadStatistics().writeOps += count;
}
/**