HADOOP-17267. Add debug-level logs in Filesystem.close() (#2321)
When a filesystem is closed, the FileSystem log will, at debug level, log the method calling close/closeAll. At trace level: the full calling stack. Contributed by Karen Coppage. Change-Id: I1444f065c171fd31d42b497c92ba4517969f67f0
This commit is contained in:
parent
eb6134cd22
commit
43c9959b3a
|
@ -620,6 +620,7 @@ public abstract class FileSystem extends Configured
|
|||
* @throws IOException a problem arose closing one or more filesystem.
|
||||
*/
|
||||
public static void closeAll() throws IOException {
|
||||
debugLogFileSystemClose("closeAll", "");
|
||||
CACHE.closeAll();
|
||||
}
|
||||
|
||||
|
@ -630,10 +631,24 @@ public abstract class FileSystem extends Configured
|
|||
* @throws IOException a problem arose closing one or more filesystem.
|
||||
*/
|
||||
public static void closeAllForUGI(UserGroupInformation ugi)
|
||||
throws IOException {
|
||||
throws IOException {
|
||||
debugLogFileSystemClose("closeAllForUGI", "UGI: " + ugi);
|
||||
CACHE.closeAll(ugi);
|
||||
}
|
||||
|
||||
private static void debugLogFileSystemClose(String methodName,
|
||||
String additionalInfo) {
|
||||
if (LOGGER.isDebugEnabled()) {
|
||||
Throwable throwable = new Throwable().fillInStackTrace();
|
||||
LOGGER.debug("FileSystem.{}() by method: {}); {}", methodName,
|
||||
throwable.getStackTrace()[2], additionalInfo);
|
||||
if (LOGGER.isTraceEnabled()) {
|
||||
LOGGER.trace("FileSystem.{}() full stack trace:", methodName,
|
||||
throwable);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Qualify a path to one which uses this FileSystem and, if relative,
|
||||
* made absolute.
|
||||
|
@ -2569,6 +2584,9 @@ public abstract class FileSystem extends Configured
|
|||
*/
|
||||
@Override
|
||||
public void close() throws IOException {
|
||||
debugLogFileSystemClose("close", "Key: " + key + "; URI: " + getUri()
|
||||
+ "; Object Identity Hash: "
|
||||
+ Integer.toHexString(System.identityHashCode(this)));
|
||||
// delete all files that were marked as delete-on-exit.
|
||||
processDeleteOnExit();
|
||||
CACHE.remove(this.key, this);
|
||||
|
|
Loading…
Reference in New Issue