From 45ec3e18e33bd93a26b24a33c95d13afbe0a313d Mon Sep 17 00:00:00 2001 From: Nanda kumar Date: Thu, 1 Mar 2018 19:02:24 +0900 Subject: [PATCH] HADOOP-15275. Incorrect javadoc for return type of RetryPolicy#shouldRetry Signed-off-by: Akira Ajisaka (cherry picked from commit 55d04a6db10d0e58cfe0ff82fa646bb6ba57aaac) --- .../main/java/org/apache/hadoop/io/retry/RetryPolicy.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicy.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicy.java index 20c0307e379..5cb1bab1a5c 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicy.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicy.java @@ -89,9 +89,10 @@ public interface RetryPolicy { * {@link Idempotent} or {@link AtMostOnce} and so can reasonably be * retried on failover when we don't know if the previous attempt * reached the server or not - * @return true if the method should be retried, - * false if the method should not be retried but - * shouldn't fail with an exception (only for void methods) + * @return {@link RetryAction} with {@code RetryDecision.FAIL} if the method + * should not be retried, {@code RetryDecision.RETRY} if the method + * should be retried or {@code RetryDecision.FAILOVER_AND_RETRY} + * if failover has to be performed before retry. * @throws Exception The re-thrown exception e indicating that * the method failed and should not be retried further */