diff --git a/hadoop-ozone/dist/src/main/smoketest/s3/README.md b/hadoop-ozone/dist/src/main/smoketest/s3/README.md index 884ba2e2c79..70ccda7c35e 100644 --- a/hadoop-ozone/dist/src/main/smoketest/s3/README.md +++ b/hadoop-ozone/dist/src/main/smoketest/s3/README.md @@ -23,5 +23,5 @@ You need to 3. Set bucket/endpointurl during the robot test execution ``` -robot -v bucket:ozonetest -v OZONE_S3_SET_CREDENTIALS:false -v ENDPOINT_URL:https://s3.us-east-2.amazonaws.com smoketest/s3 +robot -v bucket:ozonetest -v OZONE_TEST:false -v OZONE_S3_SET_CREDENTIALS:false -v ENDPOINT_URL:https://s3.us-east-2.amazonaws.com smoketest/s3 ``` diff --git a/hadoop-ozone/s3gateway/pom.xml b/hadoop-ozone/s3gateway/pom.xml index 06012cf0469..52eee5d46b2 100644 --- a/hadoop-ozone/s3gateway/pom.xml +++ b/hadoop-ozone/s3gateway/pom.xml @@ -174,5 +174,11 @@ 2.15.0 test + + com.google.code.findbugs + findbugs + 3.0.1 + provided + diff --git a/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java b/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java index 04e23487b9b..bfbbb333d23 100644 --- a/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java +++ b/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java @@ -46,6 +46,7 @@ import org.apache.hadoop.ozone.s3.endpoint.MultiDeleteResponse.Error; import org.apache.hadoop.ozone.s3.exception.OS3Exception; import org.apache.hadoop.ozone.s3.exception.S3ErrorTable; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.apache.commons.lang3.StringUtils; import org.apache.hadoop.ozone.s3.util.S3utils; import org.apache.http.HttpStatus; @@ -70,6 +71,7 @@ public class BucketEndpoint extends EndpointBase { * for more details. */ @GET + @SuppressFBWarnings public Response list( @PathParam("bucket") String bucketName, @QueryParam("delimiter") String delimiter, @@ -83,12 +85,12 @@ public class BucketEndpoint extends EndpointBase { @Context HttpHeaders hh) throws OS3Exception, IOException { if (browser != null) { - try (InputStream browserPage = getClass() - .getResourceAsStream("/browser.html")) { - return Response.ok(browserPage, + InputStream browserPage = getClass() + .getResourceAsStream("/browser.html"); + return Response.ok(browserPage, MediaType.TEXT_HTML_TYPE) .build(); - } + } if (prefix == null) { @@ -295,7 +297,8 @@ public class BucketEndpoint extends EndpointBase { keyMetadata.setSize(next.getDataSize()); keyMetadata.setETag("" + next.getModificationTime()); keyMetadata.setStorageClass("STANDARD"); - keyMetadata.setLastModified(Instant.ofEpochMilli(next.getModificationTime())); + keyMetadata.setLastModified(Instant.ofEpochMilli( + next.getModificationTime())); response.addKey(keyMetadata); } }