Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-9839. Reduce verbosity of processReport logging. (Contributed by Arpit Agarwal) 

This closes #78
This commit is contained in:
Arpit Agarwal 2016-02-20 23:19:09 -08:00
parent d31660ef4a
commit 4823fbb490
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -1785,6 +1785,8 @@ Release 2.8.0 - UNRELEASED
HDFS-6832. Fix the usage of 'hdfs namenode' command.
(Manjunath Ballur via aajisaka)
HDFS-9839. Reduce verbosity of processReport logging. (Arpit Agarwal)
Release 2.7.3 - UNRELEASED
INCOMPATIBLE CHANGES

18
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
View File

@ -1825,7 +1825,7 @@ public boolean processReport(final DatanodeID nodeID,
final long startTime = Time.monotonicNow(); //after acquiring write lock
final long endTime;
DatanodeDescriptor node;
Collection<Block> invalidatedBlocks = null;
Collection<Block> invalidatedBlocks = Collections.emptyList();
try {
node = datanodeManager.getDatanode(nodeID);
@ -1900,11 +1900,9 @@ public boolean processReport(final DatanodeID nodeID,
namesystem.writeUnlock();
}
if (invalidatedBlocks != null) {
for (Block b : invalidatedBlocks) {
blockLog.info("BLOCK* processReport: {} on node {} size {} does not " +
"belong to any file", b, node, b.getNumBytes());
}
for (Block b : invalidatedBlocks) {
blockLog.debug("BLOCK* processReport: {} on node {} size {} does not " +
"belong to any file", b, node, b.getNumBytes());
}
// Log the block report processing stats from Namenode perspective
@ -1913,9 +1911,11 @@ public boolean processReport(final DatanodeID nodeID,
metrics.addBlockReport((int) (endTime - startTime));
}
blockLog.info("BLOCK* processReport: from storage {} node {}, " +
"blocks: {}, hasStaleStorage: {}, processing time: {} msecs", storage
.getStorageID(), nodeID, newReport.getNumberOfBlocks(),
node.hasStaleStorages(), (endTime - startTime));
"blocks: {}, hasStaleStorage: {}, processing time: {} msecs, " +
"invalidatedBlocks: {}", storage.getStorageID(), nodeID,
newReport.getNumberOfBlocks(),
node.hasStaleStorages(), (endTime - startTime),
invalidatedBlocks.size());
return !node.hasStaleStorages();
}