diff --git a/hdfs/CHANGES.txt b/hdfs/CHANGES.txt index 02aade46a25..08a032d7a0a 100644 --- a/hdfs/CHANGES.txt +++ b/hdfs/CHANGES.txt @@ -772,8 +772,10 @@ Trunk (unreleased changes) HDFS-1734. 'Chunk size to view' option is not working in Name Node UI. (Uma Maheswara Rao G via jitendra) - HDFS-2086. If the include hosts list contains host names, after restarting - namenode, data nodes registration is denied. Contributed by Tanping Wang. + HDFS-2086. If the include hosts list contains host names, after restarting + namenode, data nodes registration is denied. Contributed by Tanping Wang. + + HDFS-2082. SecondaryNameNode web interface doesn't show the right info. (atm) Release 0.22.0 - Unreleased diff --git a/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java b/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java index f0d14cfce72..120fdaa214a 100644 --- a/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java +++ b/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java @@ -212,7 +212,7 @@ public HttpServer run() throws IOException, InterruptedException { infoServer.addSslListener(secInfoSocAddr, conf, false, true); } - infoServer.setAttribute("secondary.name.node", this); + infoServer.setAttribute("secondary.name.node", SecondaryNameNode.this); infoServer.setAttribute("name.system.image", checkpointImage); infoServer.setAttribute(JspHelper.CURRENT_CONF, conf); infoServer.addInternalServlet("getimage", "/getimage", diff --git a/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java b/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java new file mode 100644 index 00000000000..b11e26c0644 --- /dev/null +++ b/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdfs.server.namenode; + +import static org.junit.Assert.*; + +import java.io.IOException; +import java.net.URL; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hdfs.DFSConfigKeys; +import org.apache.hadoop.hdfs.DFSTestUtil; +import org.apache.hadoop.hdfs.MiniDFSCluster; +import org.junit.Test; + +public class TestSecondaryWebUi { + + @SuppressWarnings("deprecation") + @Test + public void testSecondaryWebUi() throws IOException { + Configuration conf = new Configuration(); + conf.set(DFSConfigKeys.DFS_NAMENODE_SECONDARY_HTTP_ADDRESS_KEY, + "0.0.0.0:0"); + MiniDFSCluster cluster = null; + SecondaryNameNode snn = null; + try { + cluster = new MiniDFSCluster.Builder(conf).numDataNodes(0) + .build(); + cluster.waitActive(); + + snn = new SecondaryNameNode(conf); + String pageContents = DFSTestUtil.urlGet(new URL("http://localhost:" + + SecondaryNameNode.getHttpAddress(conf).getPort() + "/status.jsp")); + assertTrue(pageContents.contains("Last Checkpoint Time")); + } finally { + if (cluster != null) { + cluster.shutdown(); + } + if (snn != null) { + snn.shutdown(); + } + } + } +}