diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java index 0cb387e35c6..80061d32e6f 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java @@ -147,6 +147,9 @@ class BlockSender implements java.io.Closeable { /** The reference to the volume where the block is located */ private FsVolumeReference volumeRef; + /** The replica of the block that is being read. */ + private final Replica replica; + // Cache-management related fields private final long readaheadLength; @@ -229,7 +232,6 @@ class BlockSender implements java.io.Closeable { "If verifying checksum, currently must also send it."); } - final Replica replica; final long replicaVisibleLength; synchronized(datanode.data) { replica = getReplica(block, datanode); @@ -680,8 +682,12 @@ class BlockSender implements java.io.Closeable { checksum.update(buf, dOff, dLen); if (!checksum.compare(buf, cOff)) { long failedPos = offset + datalen - dLeft; - throw new ChecksumException("Checksum failed at " + failedPos, - failedPos); + StringBuilder replicaInfoString = new StringBuilder(); + if (replica != null) { + replicaInfoString.append(" for replica: " + replica.toString()); + } + throw new ChecksumException("Checksum failed at " + failedPos + + replicaInfoString, failedPos); } dLeft -= dLen; dOff += dLen; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java index 212e13b369d..ad546d2259b 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java @@ -282,12 +282,13 @@ public class VolumeScanner extends Thread { volume.getBasePath(), block); return; } - LOG.warn("Reporting bad {} on {}", block, volume.getBasePath()); + LOG.warn("Reporting bad " + block + " with volume " + + volume.getBasePath(), e); try { scanner.datanode.reportBadBlocks(block); } catch (IOException ie) { // This is bad, but not bad enough to shut down the scanner. - LOG.warn("Cannot report bad " + block.getBlockId(), e); + LOG.warn("Cannot report bad block " + block, ie); } } }