From 5308a0ecd5d2d31ac92122ed517e24449137184c Mon Sep 17 00:00:00 2001 From: Suresh Srinivas Date: Mon, 24 Sep 2012 23:16:04 +0000 Subject: [PATCH] HADOOP-8813. Add InterfaceAudience and InterfaceStability annotations to RPC Server and Client classes. Contributed by Brandon Li. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1389649 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/main/java/org/apache/hadoop/ipc/Client.java | 2 ++ .../src/main/java/org/apache/hadoop/ipc/RPC.java | 4 ++++ .../src/main/java/org/apache/hadoop/ipc/Server.java | 3 +++ 4 files changed, 12 insertions(+) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 1ff691e3197..2a8a11d7e95 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -225,6 +225,9 @@ Trunk (Unreleased) HADOOP-8151. Error handling in snappy decompressor throws invalid exceptions. (Matt Foley via harsh) + HADOOP-8813. Add InterfaceAudience and InterfaceStability annotations + to RPC Server and Client classes. (Brandon Li via suresh) + OPTIMIZATIONS HADOOP-7761. Improve the performance of raw comparisons. (todd) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java index de7af1b6b09..a67db2d990f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java @@ -83,6 +83,8 @@ import org.apache.hadoop.util.Time; * * @see Server */ +@InterfaceAudience.LimitedPrivate(value = { "Common", "HDFS", "MapReduce", "Yarn" }) +@InterfaceStability.Evolving public class Client { public static final Log LOG = LogFactory.getLog(Client.class); diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java index 46f787b402b..8ee22aa415a 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java @@ -48,6 +48,8 @@ import org.apache.hadoop.security.SaslRpcServer; import org.apache.hadoop.security.UserGroupInformation; import org.apache.hadoop.security.token.SecretManager; import org.apache.hadoop.security.token.TokenIdentifier; +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.conf.*; import org.apache.hadoop.util.ReflectionUtils; import org.apache.hadoop.util.Time; @@ -72,6 +74,8 @@ import com.google.protobuf.BlockingService; * All methods in the protocol should throw only IOException. No field data of * the protocol instance is transmitted. */ +@InterfaceAudience.LimitedPrivate(value = { "Common", "HDFS", "MapReduce", "Yarn" }) +@InterfaceStability.Evolving public class RPC { public enum RpcKind { RPC_BUILTIN ((short) 1), // Used for built in calls by tests diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java index bc3317120f5..66c81c2da05 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java @@ -64,6 +64,7 @@ import javax.security.sasl.SaslServer; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration.IntegerRanges; import org.apache.hadoop.fs.CommonConfigurationKeys; @@ -107,6 +108,8 @@ import com.google.common.annotations.VisibleForTesting; * * @see Client */ +@InterfaceAudience.LimitedPrivate(value = { "Common", "HDFS", "MapReduce", "Yarn" }) +@InterfaceStability.Evolving public abstract class Server { private final boolean authorize; private boolean isSecurityEnabled;