YARN-3005. [JDK7] Use switch statement for String instead of if-else statement in RegistrySecurity.java (Contributed by Kengo Seki)

This commit is contained in:
Akira Ajisaka 2015-01-15 21:27:39 +09:00
parent db51548f70
commit 533e551eb4
2 changed files with 11 additions and 5 deletions

View File

@ -80,6 +80,9 @@ Release 2.7.0 - UNRELEASED
IMPROVEMENTS
YARN-3005. [JDK7] Use switch statement for String instead of if-else
statement in RegistrySecurity.java (Kengo Seki via aajisaka)
YARN-2950. Change message to mandate, not suggest JS requirement on UI.
(Dustin Cote via harsh)

View File

@ -192,14 +192,17 @@ public class RegistrySecurity extends AbstractService {
String auth = conf.getTrimmed(KEY_REGISTRY_CLIENT_AUTH,
REGISTRY_CLIENT_AUTH_ANONYMOUS);
// TODO JDK7 SWITCH
if (REGISTRY_CLIENT_AUTH_KERBEROS.equals(auth)) {
switch (auth) {
case REGISTRY_CLIENT_AUTH_KERBEROS:
access = AccessPolicy.sasl;
} else if (REGISTRY_CLIENT_AUTH_DIGEST.equals(auth)) {
break;
case REGISTRY_CLIENT_AUTH_DIGEST:
access = AccessPolicy.digest;
} else if (REGISTRY_CLIENT_AUTH_ANONYMOUS.equals(auth)) {
break;
case REGISTRY_CLIENT_AUTH_ANONYMOUS:
access = AccessPolicy.anon;
} else {
break;
default:
throw new ServiceStateException(E_UNKNOWN_AUTHENTICATION_MECHANISM
+ "\"" + auth + "\"");
}