Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-15907. Reduce Memory Overhead of AclFeature by avoiding AtomicInteger. Contributed by Stephen O'Donnell.

This commit is contained in:
Ayush Saxena 2021-03-24 02:10:02 +05:30
parent 174f3a96b1
commit 569e407f64
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclFeature.java
View File

@ -19,7 +19,6 @@
package org.apache.hadoop.hdfs.server.namenode; package org.apache.hadoop.hdfs.server.namenode;
import java.util.Arrays; import java.util.Arrays;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.fs.permission.AclEntry; import org.apache.hadoop.fs.permission.AclEntry;
@ -35,7 +34,7 @@ import org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableList;
public class AclFeature implements INode.Feature, ReferenceCounter { public class AclFeature implements INode.Feature, ReferenceCounter {
public static final ImmutableList<AclEntry> EMPTY_ENTRY_LIST = public static final ImmutableList<AclEntry> EMPTY_ENTRY_LIST =
ImmutableList.of(); ImmutableList.of();
private AtomicInteger value = new AtomicInteger(); private int refCount = 0;
private final int [] entries; private final int [] entries;
@ -84,17 +83,17 @@ public class AclFeature implements INode.Feature, ReferenceCounter {
} }
@Override @Override
public int getRefCount() { public synchronized int getRefCount() {
return value.get(); return refCount;
} }
@Override @Override
public int incrementAndGetRefCount() { public synchronized int incrementAndGetRefCount() {
return value.incrementAndGet(); return ++refCount;
} }
@Override @Override
public int decrementAndGetRefCount() { public synchronized int decrementAndGetRefCount() {
return value.updateAndGet(i -> i > 0 ? i - 1 : i); return (refCount > 0) ? --refCount : 0;
} }
} }