From 599b00e087b6ee6819b93ee0203c8d95a1cf992d Mon Sep 17 00:00:00 2001 From: Suresh Srinivas Date: Fri, 24 May 2013 22:47:19 +0000 Subject: [PATCH] MAPREDUCE-5191. Merge r1484575 from trunk git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1486245 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-mapreduce-project/CHANGES.txt | 3 +++ .../org/apache/hadoop/mapred/TestQueue.java | 18 ++++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hadoop-mapreduce-project/CHANGES.txt b/hadoop-mapreduce-project/CHANGES.txt index e58e06edba9..ecc1968e79c 100644 --- a/hadoop-mapreduce-project/CHANGES.txt +++ b/hadoop-mapreduce-project/CHANGES.txt @@ -147,6 +147,9 @@ Release 2.0.5-beta - UNRELEASED classpath problems and unexpected behavior of symlinks (Chris Nauroth via bikas) + MAPREDUCE-5191. TestQueue#testQueue fails with timeout on Windows. (Ivan + Mitic via hitesh) + BREAKDOWN OF HADOOP-8562 SUBTASKS MAPREDUCE-4739. Some MapReduce tests fail to find winutils. diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java index 5fe5c3ac0cd..4313e4080e2 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java @@ -28,8 +28,11 @@ import java.util.Iterator; import java.util.Set; import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileUtil; import org.apache.hadoop.mapreduce.MRConfig; import org.apache.hadoop.security.UserGroupInformation; +import org.junit.After; +import org.junit.Before; import org.junit.Test; import static junit.framework.Assert.*; @@ -39,6 +42,18 @@ import static org.mockito.Mockito.*; * TestCounters checks the sanity and recoverability of Queue */ public class TestQueue { + private static File testDir = new File(System.getProperty("test.build.data", + "/tmp"), TestJobConf.class.getSimpleName()); + + @Before + public void setup() { + testDir.mkdirs(); + } + + @After + public void cleanup() { + FileUtil.fullyDelete(testDir); + } /** * test QueueManager @@ -217,8 +232,7 @@ public class TestQueue { */ private File writeFile() throws IOException { - File f = null; - f = File.createTempFile("tst", "xml"); + File f = new File(testDir, "tst.xml"); BufferedWriter out = new BufferedWriter(new FileWriter(f)); String properties = ""; out.write("");