Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-15286. Concat on a same file deleting the file. Contributed by hemanthboyina.

This commit is contained in:
Akira Ajisaka 2020-04-28 06:16:42 +09:00
parent 6ef01646ba
commit 5e0eda5d5f
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
2 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
View File

@ -150,7 +150,7 @@ class FSDirConcatOp {
+ " is referred by some other reference in some snapshot.");
}
// source file cannot be the same with the target file
if (srcINode == targetINode) {
if (srcINode.equals(targetINode)) {
throw new HadoopIllegalArgumentException("concat: the src file " + src
+ " is the same with the target file " + targetIIP.getPath());
}

39
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
View File

@ -45,6 +45,7 @@ import org.apache.hadoop.hdfs.server.protocol.NamenodeProtocols;
import org.apache.hadoop.ipc.RemoteException;
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.hadoop.test.GenericTestUtils;
import org.apache.hadoop.test.LambdaTestUtils;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
@ -525,4 +526,42 @@ public class TestHDFSConcat {
GenericTestUtils.assertExceptionContains(errMsg, e);
}
}
/**
* Test concat on same source and target file which is a inode reference.
*/
@Test
public void testConcatOnSameFile() throws Exception {
String dir = "/dir1";
Path trgDir = new Path(dir);
dfs.mkdirs(new Path(dir));
// create a source file
String dir2 = "/dir2";
Path srcDir = new Path(dir2);
dfs.mkdirs(srcDir);
dfs.allowSnapshot(srcDir);
Path src = new Path(srcDir, "file1");
DFSTestUtil.createFile(dfs, src, 512, (short) 2, 0);
// make the file as an Inode reference and delete the reference
dfs.createSnapshot(srcDir, "s1");
dfs.rename(src, trgDir);
dfs.deleteSnapshot(srcDir, "s1");
Path[] srcs = new Path[1];
srcs[0] = new Path(dir, "file1");
// perform concat
LambdaTestUtils.intercept(RemoteException.class,
"concat: the src file /dir1/file1 is the same with the target"
+ " file /dir1/file1",
() -> dfs.concat(srcs[0], srcs));
// the file should exists and read the file
byte[] buff = new byte[1080];
FSDataInputStream stream = dfs.open(srcs[0]);
stream.readFully(0, buff, 0, 512);
assertEquals(1, dfs.getContentSummary(new Path(dir)).getFileCount());
}
}