From 5eb17e57265655b9c704e7fe664a29071f7902ae Mon Sep 17 00:00:00 2001 From: Vinayakumar B Date: Tue, 28 Apr 2015 14:24:17 +0530 Subject: [PATCH] HDFS-8189. ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent (Contributed by Vinayakumar B) --- .../hadoop-hdfs/CHANGES-HDFS-EC-7285.txt | 5 ++++- .../hadoop/hdfs/protocol/ClientProtocol.java | 16 ++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt index c28473bae70..6c5d7ce86c4 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt @@ -136,4 +136,7 @@ striped layout (Zhe Zhang) HDFS-8230. Erasure Coding: Ignore DatanodeProtocol#DNA_ERASURE_CODING_RECOVERY - commands from standbynode if any (vinayakumarb) \ No newline at end of file + commands from standbynode if any (vinayakumarb) + + HDFS-8189. ClientProtocol#createErasureCodingZone API was wrongly annotated + as Idempotent (vinayakumarb) \ No newline at end of file diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java index bba7697bbe5..76e2d12d9ba 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java @@ -1363,14 +1363,6 @@ public interface ClientProtocol { public BatchedEntries listEncryptionZones( long prevId) throws IOException; - /** - * Create an erasure coding zone with specified schema, if any, otherwise - * default - */ - @Idempotent - public void createErasureCodingZone(String src, ECSchema schema) - throws IOException; - /** * Set xattr of a file or directory. * The name must be prefixed with the namespace followed by ".". For example, @@ -1466,6 +1458,14 @@ public interface ClientProtocol { @Idempotent public EventBatchList getEditsFromTxid(long txid) throws IOException; + /** + * Create an erasure coding zone with specified schema, if any, otherwise + * default + */ + @AtMostOnce + public void createErasureCodingZone(String src, ECSchema schema) + throws IOException; + /** * Gets the ECInfo for the specified file/directory *