diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java index 16b67844690..88259656f25 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java @@ -85,6 +85,10 @@ public static enum Mode { CLIENT, SERVER } private Mode mode; private boolean requireClientCert; private SSLContext context; + // the java keep-alive cache relies on instance equivalence of the SSL socket + // factory. in many java versions, SSLContext#getSocketFactory always + // returns a new instance which completely breaks the cache... + private SSLSocketFactory socketFactory; private HostnameVerifier hostnameVerifier; private KeyStoresFactory keystoresFactory; @@ -150,6 +154,9 @@ public void init() throws GeneralSecurityException, IOException { context.init(keystoresFactory.getKeyManagers(), keystoresFactory.getTrustManagers(), null); context.getDefaultSSLParameters().setProtocols(enabledProtocols); + if (mode == Mode.CLIENT) { + socketFactory = context.getSocketFactory(); + } hostnameVerifier = getHostnameVerifier(conf); } @@ -270,7 +277,7 @@ public SSLSocketFactory createSSLSocketFactory() throw new IllegalStateException( "Factory is not in CLIENT mode. Actual mode is " + mode.toString()); } - return context.getSocketFactory(); + return socketFactory; } /**