diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java index ba653ac0d2d..84569f31f34 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java @@ -786,8 +786,14 @@ class FsDatasetImpl implements FsDatasetSpi { throws ReplicaNotFoundException { ReplicaInfo info = volumeMap.get(b.getBlockPoolId(), b.getLocalBlock()); if (info == null) { - throw new ReplicaNotFoundException( - ReplicaNotFoundException.NON_EXISTENT_REPLICA + b); + if (volumeMap.get(b.getBlockPoolId(), b.getLocalBlock().getBlockId()) + == null) { + throw new ReplicaNotFoundException( + ReplicaNotFoundException.NON_EXISTENT_REPLICA + b); + } else { + throw new ReplicaNotFoundException( + ReplicaNotFoundException.UNEXPECTED_GS_REPLICA + b); + } } return info; } @@ -1878,16 +1884,21 @@ class FsDatasetImpl implements FsDatasetSpi { try (AutoCloseableLock lock = datasetLock.acquire()) { final ReplicaInfo info = volumeMap.get(bpid, invalidBlks[i]); if (info == null) { - // It is okay if the block is not found -- it may be deleted earlier. - LOG.info("Failed to delete replica " + invalidBlks[i] - + ": ReplicaInfo not found."); - continue; - } - if (info.getGenerationStamp() != invalidBlks[i].getGenerationStamp()) { - errors.add("Failed to delete replica " + invalidBlks[i] - + ": GenerationStamp not matched, info=" + info); + ReplicaInfo infoByBlockId = + volumeMap.get(bpid, invalidBlks[i].getBlockId()); + if (infoByBlockId == null) { + // It is okay if the block is not found -- it + // may be deleted earlier. + LOG.info("Failed to delete replica " + invalidBlks[i] + + ": ReplicaInfo not found."); + } else { + errors.add("Failed to delete replica " + invalidBlks[i] + + ": GenerationStamp not matched, existing replica is " + + Block.toString(infoByBlockId)); + } continue; } + v = (FsVolumeImpl)info.getVolume(); if (v == null) { errors.add("Failed to delete replica " + invalidBlks[i]