Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-14902. LoadGenerator#genFile write close timing is incorrectly calculated. Contributed by Hanisha Koneru

This commit is contained in:
Jason Lowe 2017-09-28 16:38:30 -05:00
parent ca669f9f8b
commit 6f789fe057
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
View File

@ -322,6 +322,7 @@ public class LoadGenerator extends Configured implements Tool {
private void genFile(Path file, long fileSize) throws IOException { private void genFile(Path file, long fileSize) throws IOException {
long startTimestamp = Time.monotonicNow(); long startTimestamp = Time.monotonicNow();
FSDataOutputStream out = null; FSDataOutputStream out = null;
boolean isOutClosed = false;
try { try {
out = fc.create(file, out = fc.create(file,
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE), EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE),
@ -337,11 +338,15 @@ public class LoadGenerator extends Configured implements Tool {
i -= s; i -= s;
} }
startTimestamp = Time.monotonicNow(); startTime = Time.monotonicNow();
executionTime[WRITE_CLOSE] += (Time.monotonicNow() - startTimestamp); out.close();
executionTime[WRITE_CLOSE] += (Time.monotonicNow() - startTime);
numOfOps[WRITE_CLOSE]++; numOfOps[WRITE_CLOSE]++;
isOutClosed = true;
} finally { } finally {
IOUtils.cleanupWithLogger(LOG, out); if (!isOutClosed && out != null) {
out.close();
}
} }
} }
} }