Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix pending checkstyles & test cases

This commit is contained in:
krgoyal krgoyal 2023-03-06 17:09:40 +05:30
parent 7a73e38b46
commit 6ff0d7defb
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestMemoryFederationStateStore.java
View File

@ -31,7 +31,6 @@ import org.apache.hadoop.yarn.server.federation.store.records.RouterStoreToken;
import java.io.IOException; import java.io.IOException;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.util.Map; import java.util.Map;
import java.util.Set;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
@ -82,7 +81,7 @@ public class TestMemoryFederationStateStore extends FederationStateStoreBaseTest
secretManagerState.getTokenState(); secretManagerState.getTokenState();
assertNotNull(tokenStateMap); assertNotNull(tokenStateMap);
assertTrue(tokenStateMap.containsKey(identifier)); assertTrue(tokenStateMap.containsKey(identifier.getSequenceNumber()));
YARNDelegationTokenIdentifier tokenIdentifier = token.getTokenIdentifier(); YARNDelegationTokenIdentifier tokenIdentifier = token.getTokenIdentifier();
assertTrue(tokenIdentifier instanceof RMDelegationTokenIdentifier); assertTrue(tokenIdentifier instanceof RMDelegationTokenIdentifier);

10
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/security/RouterDelegationTokenSecretManager.java
View File

@ -36,24 +36,24 @@ import java.nio.ByteBuffer;
import java.util.Base64; import java.util.Base64;
/** /**
* A Router specific delegation token secret manager & is designed to be stateless. * A Router specific delegation token secret manager and is designed to be stateless.
* The secret manager is responsible for generating and accepting the password * The secret manager is responsible for generating and accepting the password
* for each token. * for each token.
* *
* Behavioural Differences from AbstractDelegationTokenSecretManager * Behavioural Differences from AbstractDelegationTokenSecretManager
* 1) Master Key - Each instance of Router will have its own master key & each instance rolls its own master key. * 1) Master Key - Each instance of Router will have its own master key and each instance rolls its own master key.
* Thus there is no concept of a global current key. * Thus there is no concept of a global current key.
* The requirement to generate new master keys / delegation tokens is to generate unique INTEGER keys, * The requirement to generate new master keys / delegation tokens is to generate unique INTEGER keys,
* which the state store is responsible for (Autoincrement is one of the ways to achieve this). * which the state store is responsible for (Autoincrement is one of the ways to achieve this).
* This key will be regenerated on service restart & thus there is no requirement of an explicit restore mechanism. * This key will be regenerated on service restart and thus there is no requirement of an explicit restore mechanism.
* Current master key will be stored in memory on each instance & will be used to generate new tokens. * Current master key will be stored in memory on each instance and will be used to generate new tokens.
* Master key will be looked up from the state store for Validation / renewal, etc of tokens. * Master key will be looked up from the state store for Validation / renewal, etc of tokens.
* *
* 2) Token Expiry - It doesn't take care of token removal on expiry. * 2) Token Expiry - It doesn't take care of token removal on expiry.
* Each state store can implement its own way to manage token deletion on expiry. * Each state store can implement its own way to manage token deletion on expiry.
* *
* This pretty much replaces all methods of AbstractDelegationTokenSecretManager which is designed for stateful managers * This pretty much replaces all methods of AbstractDelegationTokenSecretManager which is designed for stateful managers
* TODO - Refactor Secret Manager interfaces to support stateful & stateless secret management * TODO - Refactor Secret Manager interfaces to support stateful and stateless secret management
*/ */
public class RouterDelegationTokenSecretManager public class RouterDelegationTokenSecretManager
extends AbstractDelegationTokenSecretManager<RMDelegationTokenIdentifier> { extends AbstractDelegationTokenSecretManager<RMDelegationTokenIdentifier> {