Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-18710. Add RPC metrics for response time (#5545). Contributed by liuguanghua. 

Reviewed-by: Inigo Goiri <inigoiri@apache.org>
Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This commit is contained in:
LiuGuH 2023-04-22 03:36:08 +08:00 committed by GitHub
parent 964c1902c8
commit 742e07d9c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
View File

@ -627,8 +627,11 @@ public abstract class Server {
details.get(Timing.PROCESSING, rpcMetrics.getMetricsTimeUnit()); details.get(Timing.PROCESSING, rpcMetrics.getMetricsTimeUnit());
long waitTime = long waitTime =
details.get(Timing.LOCKWAIT, rpcMetrics.getMetricsTimeUnit()); details.get(Timing.LOCKWAIT, rpcMetrics.getMetricsTimeUnit());
long responseTime =
details.get(Timing.RESPONSE, rpcMetrics.getMetricsTimeUnit());
rpcMetrics.addRpcLockWaitTime(waitTime); rpcMetrics.addRpcLockWaitTime(waitTime);
rpcMetrics.addRpcProcessingTime(processingTime); rpcMetrics.addRpcProcessingTime(processingTime);
rpcMetrics.addRpcResponseTime(responseTime);
// don't include lock wait for detailed metrics. // don't include lock wait for detailed metrics.
processingTime -= waitTime; processingTime -= waitTime;
String name = call.getDetailedMetricsName(); String name = call.getDetailedMetricsName();

17
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
View File

@ -75,6 +75,8 @@ public class RpcMetrics {
new MutableQuantiles[intervals.length]; new MutableQuantiles[intervals.length];
rpcProcessingTimeQuantiles = rpcProcessingTimeQuantiles =
new MutableQuantiles[intervals.length]; new MutableQuantiles[intervals.length];
rpcResponseTimeQuantiles =
new MutableQuantiles[intervals.length];
deferredRpcProcessingTimeQuantiles = deferredRpcProcessingTimeQuantiles =
new MutableQuantiles[intervals.length]; new MutableQuantiles[intervals.length];
for (int i = 0; i < intervals.length; i++) { for (int i = 0; i < intervals.length; i++) {
@ -90,6 +92,10 @@ public class RpcMetrics {
"rpcProcessingTime" + interval + "s", "rpcProcessingTime" + interval + "s",
"rpc processing time in " + metricsTimeUnit, "ops", "rpc processing time in " + metricsTimeUnit, "ops",
"latency", interval); "latency", interval);
rpcResponseTimeQuantiles[i] = registry.newQuantiles(
"rpcResponseTime" + interval + "s",
"rpc response time in " + metricsTimeUnit, "ops",
"latency", interval);
deferredRpcProcessingTimeQuantiles[i] = registry.newQuantiles( deferredRpcProcessingTimeQuantiles[i] = registry.newQuantiles(
"deferredRpcProcessingTime" + interval + "s", "deferredRpcProcessingTime" + interval + "s",
"deferred rpc processing time in " + metricsTimeUnit, "ops", "deferred rpc processing time in " + metricsTimeUnit, "ops",
@ -114,6 +120,8 @@ public class RpcMetrics {
MutableQuantiles[] rpcLockWaitTimeQuantiles; MutableQuantiles[] rpcLockWaitTimeQuantiles;
@Metric("Processing time") MutableRate rpcProcessingTime; @Metric("Processing time") MutableRate rpcProcessingTime;
MutableQuantiles[] rpcProcessingTimeQuantiles; MutableQuantiles[] rpcProcessingTimeQuantiles;
@Metric("Response time") MutableRate rpcResponseTime;
MutableQuantiles[] rpcResponseTimeQuantiles;
@Metric("Deferred Processing time") MutableRate deferredRpcProcessingTime; @Metric("Deferred Processing time") MutableRate deferredRpcProcessingTime;
MutableQuantiles[] deferredRpcProcessingTimeQuantiles; MutableQuantiles[] deferredRpcProcessingTimeQuantiles;
@Metric("Number of authentication failures") @Metric("Number of authentication failures")
@ -282,6 +290,15 @@ public class RpcMetrics {
} }
} }
public void addRpcResponseTime(long responseTime) {
rpcResponseTime.add(responseTime);
if (rpcQuantileEnable) {
for (MutableQuantiles q : rpcResponseTimeQuantiles) {
q.add(responseTime);
}
}
}
public void addDeferredRpcProcessingTime(long processingTime) { public void addDeferredRpcProcessingTime(long processingTime) {
deferredRpcProcessingTime.add(processingTime); deferredRpcProcessingTime.add(processingTime);
if (rpcQuantileEnable) { if (rpcQuantileEnable) {

4
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
View File

@ -1336,12 +1336,16 @@ public class TestRPC extends TestRpcBase {
3000, getLongCounter("RpcProcessingTimeNumOps", rpcMetrics)); 3000, getLongCounter("RpcProcessingTimeNumOps", rpcMetrics));
assertEquals("Expected correct rpc lock wait count", assertEquals("Expected correct rpc lock wait count",
3000, getLongCounter("RpcLockWaitTimeNumOps", rpcMetrics)); 3000, getLongCounter("RpcLockWaitTimeNumOps", rpcMetrics));
assertEquals("Expected correct rpc response count",
3000, getLongCounter("RpcResponseTimeNumOps", rpcMetrics));
assertEquals("Expected zero rpc lock wait time", assertEquals("Expected zero rpc lock wait time",
0, getDoubleGauge("RpcLockWaitTimeAvgTime", rpcMetrics), 0.001); 0, getDoubleGauge("RpcLockWaitTimeAvgTime", rpcMetrics), 0.001);
MetricsAsserts.assertQuantileGauges("RpcQueueTime" + interval + "s", MetricsAsserts.assertQuantileGauges("RpcQueueTime" + interval + "s",
rpcMetrics); rpcMetrics);
MetricsAsserts.assertQuantileGauges("RpcProcessingTime" + interval + "s", MetricsAsserts.assertQuantileGauges("RpcProcessingTime" + interval + "s",
rpcMetrics); rpcMetrics);
MetricsAsserts.assertQuantileGauges("RpcResponseTime" + interval + "s",
rpcMetrics);
String actualUserVsCon = MetricsAsserts String actualUserVsCon = MetricsAsserts
.getStringMetric("NumOpenConnectionsPerUser", rpcMetrics); .getStringMetric("NumOpenConnectionsPerUser", rpcMetrics);
String proxyUser = String proxyUser =